From: Donald Dutile <ddutile@redhat.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>, qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
eric.auger@redhat.com, nicolinc@nvidia.com,
joao.m.martins@oracle.com, chao.p.peng@intel.com
Subject: Re: [PATCH 2/5] vfio: Move realize() after attach_device()
Date: Fri, 18 Apr 2025 16:56:00 -0400 [thread overview]
Message-ID: <0e8743d2-ed08-4dec-8689-999abdfd944e@redhat.com> (raw)
In-Reply-To: <20250411101707.3460429-3-zhenzhong.duan@intel.com>
On 4/11/25 6:17 AM, Zhenzhong Duan wrote:
> Previously device attaching depends on realize() getting host iommu capabilities to check dirty tracking support. Now we save a caps copy in VFIODevice and check that copy for dirty tracking support, there is no dependency any more, move realize() call after attach_device() call in vfio_device_attach(). Drop vfio_device_hiod_realize() which looks redundant now. Suggested-by: Cédric Le Goater <clg@redhat.com> Suggested-by: Donald Dutile <ddutile@redhat.com> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Donald Dutile <ddutile@redhat.com>
next prev parent reply other threads:[~2025-04-18 20:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 10:17 [PATCH 0/5] cleanup interfaces Zhenzhong Duan
2025-04-11 10:17 ` [PATCH 1/5] vfio/iommufd: Save host iommu capabilities in VFIODevice.caps Zhenzhong Duan
2025-04-11 10:49 ` Joao Martins
2025-04-14 9:11 ` Duan, Zhenzhong
2025-04-11 11:28 ` Cédric Le Goater
2025-04-14 9:30 ` Duan, Zhenzhong
[not found] ` <Z/7z2RZyqhy43S/O@Asurada-Nvidia>
2025-04-16 5:49 ` Duan, Zhenzhong
[not found] ` <Z//4pYO/Xs/7U+dW@Asurada-Nvidia>
2025-04-17 4:08 ` Duan, Zhenzhong
2025-05-05 16:14 ` Eric Auger
2025-05-06 9:25 ` Duan, Zhenzhong
2025-05-05 16:22 ` Eric Auger
2025-05-05 16:38 ` Eric Auger
2025-05-06 6:22 ` Nicolin Chen
2025-04-11 10:17 ` [PATCH 2/5] vfio: Move realize() after attach_device() Zhenzhong Duan
2025-04-11 10:54 ` Philippe Mathieu-Daudé
2025-04-14 9:12 ` Duan, Zhenzhong
2025-04-11 11:33 ` Cédric Le Goater
2025-04-14 9:37 ` Duan, Zhenzhong
2025-04-18 20:56 ` Donald Dutile [this message]
2025-04-11 10:17 ` [PATCH 3/5] vfio/iommufd: Implement .get_cap() in TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO sub-class Zhenzhong Duan
[not found] ` <Z/702atFa6kyCI/D@Asurada-Nvidia>
2025-04-16 5:54 ` Duan, Zhenzhong
2025-04-11 10:17 ` [PATCH 4/5] backends/iommufd: Drop hiod_iommufd_get_cap() Zhenzhong Duan
2025-04-11 10:17 ` [PATCH 5/5] vfio/iommufd: Drop HostIOMMUDeviceCaps from HostIOMMUDevice Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8743d2-ed08-4dec-8689-999abdfd944e@redhat.com \
--to=ddutile@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=nicolinc@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.