From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v3 2/3] drm/msm/dpu: handle failures while initializing displays Date: Mon, 17 Dec 2018 11:35:22 -0800 Message-ID: <0e9003608254bfe2529468e349c70cff@codeaurora.org> References: <1544727064-26763-1-git-send-email-jsanka@codeaurora.org> <1544727064-26763-2-git-send-email-jsanka@codeaurora.org> <20181214152209.GQ154160@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181214152209.GQ154160@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0xMi0xNCAwNzoyMiwgU2VhbiBQYXVsIHdyb3RlOgo+IE9uIFRodSwgRGVjIDEzLCAy MDE4IGF0IDEwOjUxOjAzQU0gLTA4MDAsIEpleWt1bWFyIFNhbmthcmFuIHdyb3RlOgo+PiBCYWls IG91dCBLTVMgaHcgaW5pdCBvbiBkaXNwbGF5IGluaXRpYWxpemF0aW9uIGZhaWx1cmVzIHdpdGgK Pj4gcHJvcGVyIGVycm9yIGxvZ2dpbmcuCj4+IAo+PiBjaGFuZ2VzIGluIHYzOgo+PiAJLSBpbnRy b2R1Y2VkIGluIHRoZSBzZXJpZXMKPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEpleWt1bWFyIFNhbmth cmFuIDxqc2Fua2FAY29kZWF1cm9yYS5vcmc+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL21z bS9kaXNwL2RwdTEvZHB1X2ttcy5jIHwgMzkKPiArKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo LSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVf a21zLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+PiBpbmRl eCA2ODU2ODZlLi4zOWM4NTQ5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rp c3AvZHB1MS9kcHVfa21zLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEv ZHB1X2ttcy5jCj4+IEBAIC00MDUsMzMgKzQwNSwzNiBAQCBzdGF0aWMgdm9pZCBkcHVfa21zX3dh aXRfZm9yX2NvbW1pdF9kb25lKHN0cnVjdAo+IG1zbV9rbXMgKmttcywKPj4gIAl9Cj4+ICB9Cj4+ IAo+PiAtc3RhdGljIHZvaWQgX2RwdV9rbXNfaW5pdGlhbGl6ZV9kc2koc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPj4gK3N0YXRpYyBpbnQgX2RwdV9rbXNfaW5pdGlhbGl6ZV9kc2koc3RydWN0IGRy bV9kZXZpY2UgKmRldiwKPj4gIAkJCQkgICAgc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiwK Pj4gIAkJCQkgICAgc3RydWN0IGRwdV9rbXMgKmRwdV9rbXMpCj4+ICB7Cj4+ICAJc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyID0gTlVMTDsKPj4gLQlpbnQgaSwgcmM7Cj4+ICsJaW50IGksIHJj ID0gMDsKPj4gKwo+PiArCWlmICghKHByaXYtPmRzaVswXSB8fCBwcml2LT5kc2lbMV0pKQo+IAo+ IEl0J2QgYmUgbmljZSB0byBub3QgaGF2ZSB0byBzdXBwb3J0IGJvdGggYmxvY2tzIGlmIG9ubHkg b25lIGlzIGhvb2tlZCAKPiB1cC4KPiBQZXJoYXBzIG1vdmUgdGhlIFRPRE8gYmVsb3cgYWJvdmUg dGhpcyBjaGVjay4KPiAKRm9yIGR1YWwgRFNJIHBhbmVscyAoZS5nOiBNVFAgcGFuZWxzKSwgYm90 aCBvZiB0aGVzZSBibG9ja3Mgd2lsbCBiZSAKcG9wdWxhdGVkLgpUT0RPIGNvbW1lbnQgYmVsb3cg aXMgdG8gY29udmV5IHRoYXQgdGhlIHN1cHBvcnQgZm9yIHR3byBpbmRlcGVuZGVudCAKc2luZ2xl IERTSQpwYW5lbHMgaXMgbm90IHlldCBhdmFpbGFibGUgaW4gRFBVLgoKVGhhbmtzIGFuZCBSZWdh cmRzLApKZXlrdW1hciBTLgo+PiArCQlyZXR1cm4gcmM7Cj4+IAo+PiAgCS8qVE9ETzogU3VwcG9y dCB0d28gaW5kZXBlbmRlbnQgRFNJIGNvbm5lY3RvcnMgKi8KPj4gIAllbmNvZGVyID0gZHB1X2Vu Y29kZXJfaW5pdChkZXYsIERSTV9NT0RFX0VOQ09ERVJfRFNJKTsKPj4gLQlpZiAoSVNfRVJSX09S X05VTEwoZW5jb2RlcikpIHsKPj4gKwlpZiAoSVNfRVJSKGVuY29kZXIpKSB7Cj4+ICAJCURQVV9F UlJPUigiZW5jb2RlciBpbml0IGZhaWxlZCBmb3IgZHNpIGRpc3BsYXlcbiIpOwo+PiAtCQlyZXR1 cm47Cj4+ICsJCXJldHVybiBQVFJfRVJSKGVuY29kZXIpOwo+PiAgCX0KPj4gCj4+ICAJZm9yIChp ID0gMDsgaSA8IEFSUkFZX1NJWkUocHJpdi0+ZHNpKTsgaSsrKSB7Cj4+IC0JCWlmICghcHJpdi0+ ZHNpW2ldKSB7Cj4+IC0JCQlEUFVfREVCVUcoImludmFsaWQgbXNtX2RzaSBmb3IgY3RybCAlZFxu IiwgaSk7Cj4+IC0JCQlyZXR1cm47Cj4+IC0JCX0KPj4gKwkJaWYgKCFwcml2LT5kc2lbaV0pCj4g Cj4gSSBkb24ndCB0aGluayB0aGlzIGlzIHBvc3NpYmxlIGdpdmVuIHRoZSBjaGVjayBhdCB0aGUg YmVnaW5uaW5nIG9mIHRoZQo+IGZ1bmN0aW9uCj4gCj4+ICsJCQljb250aW51ZTsKPj4gCj4+ICAJ CXJjID0gbXNtX2RzaV9tb2Rlc2V0X2luaXQocHJpdi0+ZHNpW2ldLCBkZXYsIGVuY29kZXIpOwo+ PiAgCQlpZiAocmMpIHsKPj4gIAkJCURQVV9FUlJPUigibW9kZXNldF9pbml0IGZhaWxlZCBmb3Ig ZHNpWyVkXSwgcmMgPQo+ICVkXG4iLAo+PiAgCQkJCWksIHJjKTsKPj4gLQkJCWNvbnRpbnVlOwo+ PiArCQkJcmV0dXJuIHJjOwo+PiAgCQl9Cj4+ICAJfQo+PiArCj4+ICsJcmV0dXJuIHJjOwo+IAo+ IG5pdDogWW91IGNhbiBrZWVwIHJjIHVuaW5pdGlhbGl6ZWQgYWJvdmUgYW5kIGp1c3QgcmV0dXJu IDAgaGVyZS4KPiAKPj4gIH0KPj4gCj4+ICAvKioKPj4gQEAgLTQ0MiwxNiArNDQ1LDI0IEBAIHN0 YXRpYyB2b2lkIF9kcHVfa21zX2luaXRpYWxpemVfZHNpKHN0cnVjdAo+IGRybV9kZXZpY2UgKmRl diwKPj4gICAqIEBkcHVfa21zOiAgICBQb2ludGVyIHRvIGRwdSBrbXMgc3RydWN0dXJlCj4+ICAg KiBSZXR1cm5zOiAgICAgWmVybyBvbiBzdWNjZXNzCj4+ICAgKi8KPj4gLXN0YXRpYyB2b2lkIF9k cHVfa21zX3NldHVwX2Rpc3BsYXlzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICtzdGF0aWMg aW50IF9kcHVfa21zX3NldHVwX2Rpc3BsYXlzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAJ CQkJICAgIHN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXYsCj4+ICAJCQkJICAgIHN0cnVjdCBk cHVfa21zICpkcHVfa21zKQo+PiAgewo+PiAtCV9kcHVfa21zX2luaXRpYWxpemVfZHNpKGRldiwg cHJpdiwgZHB1X2ttcyk7Cj4+ICsJaW50IHJjID0gMDsKPiAKPiBuaXQ6IE5vIG5lZWQgdG8gaW5p dGlhbGl6ZSB0byAwCj4gCj4+ICsKPj4gKwlyYyA9IF9kcHVfa21zX2luaXRpYWxpemVfZHNpKGRl diwgcHJpdiwgZHB1X2ttcyk7Cj4+ICsJaWYgKHJjKSB7Cj4+ICsJCURQVV9FUlJPUigiZmFpbGVk IHRvIGluaXRpYWxpemUgZHNpLCByYyA9ICVkXG4iLCByYyk7Cj4+ICsJCXJldHVybiByYzsKPj4g Kwl9Cj4+IAo+PiAgCS8qKgo+PiAgCSAqIEV4dGVuZCB0aGlzIGZ1bmN0aW9uIHRvIGluaXRpYWxp emUgb3RoZXIKPj4gIAkgKiB0eXBlcyBvZiBkaXNwbGF5cwo+PiAgCSAqLwo+PiArCj4+ICsJcmV0 dXJuIHJjOwo+PiAgfQo+PiAKPj4gIHN0YXRpYyB2b2lkIF9kcHVfa21zX2RybV9vYmpfZGVzdHJv eShzdHJ1Y3QgZHB1X2ttcyAqZHB1X2ttcykKPj4gQEAgLTUxNyw3ICs1MjgsMTEgQEAgc3RhdGlj IGludCBfZHB1X2ttc19kcm1fb2JqX2luaXQoc3RydWN0IGRwdV9rbXMKPiAqZHB1X2ttcykKPj4g IAkgKiBDcmVhdGUgZW5jb2RlciBhbmQgcXVlcnkgZGlzcGxheSBkcml2ZXJzIHRvIGNyZWF0ZQo+ PiAgCSAqIGJyaWRnZXMgYW5kIGNvbm5lY3RvcnMKPj4gIAkgKi8KPj4gLQlfZHB1X2ttc19zZXR1 cF9kaXNwbGF5cyhkZXYsIHByaXYsIGRwdV9rbXMpOwo+PiArCXJldCA9IF9kcHVfa21zX3NldHVw X2Rpc3BsYXlzKGRldiwgcHJpdiwgZHB1X2ttcyk7Cj4+ICsJaWYgKHJldCkgewo+PiArCQlEUFVf RVJST1IoImZhaWxlZCB0byBzZXR1cCBkaXNwbGF5LCByYyA9ICVkXG4iLCByZXQpOwo+PiArCQln b3RvIGZhaWw7Cj4+ICsJfQo+PiAKPj4gIAltYXhfY3J0Y19jb3VudCA9IG1pbihjYXRhbG9nLT5t aXhlcl9jb3VudCwKPj4gIAkJCSAgICAgKHUzMilkZXYtPm1vZGVfY29uZmlnLm51bV9lbmNvZGVy KTsKPj4gLS0KPj4gVGhlIFF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVt YmVyIG9mIHRoZSBDb2RlIEF1cm9yYQo+IEZvcnVtLAo+PiBhIExpbnV4IEZvdW5kYXRpb24gQ29s bGFib3JhdGl2ZSBQcm9qZWN0Cj4+IAo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+PiBGcmVlZHJlbm8gbWFpbGluZyBsaXN0Cj4+IEZyZWVkcmVub0Bs aXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9mcmVlZHJlbm8KCi0tIApKZXlrdW1hciBTCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJl ZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=