From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Joe Damato <jdamato@fastly.com>, admiyo@os.amperecomputing.com
Cc: Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Wed, 18 Dec 2024 08:09:20 +0800 [thread overview]
Message-ID: <0ea0aac339c2ee7522510f1dab5f69a27413434d.camel@codeconstruct.com.au> (raw)
In-Reply-To: <Z2HLJD8z3wFNvnlV@LQ3V64L9R2>
Hi Joe,
> I suspect what Jeremy meant (but please feel free to correct me if
> I'm mistaken, Jeremy) was that you may want to use the helpers in:
>
> include/linux/netdevice.h
No, I was just referring to the new(-ish) dstats infrastructure in the
core, with dstats collection in rtnl_link_stats64() as of 94b601bc.
However, your suggestion of:
> dev_dstats_rx_add(mctp_pcc_ndev->mdev.dev, data_len);
> dev_dstats_rx_dropped(mctp_pcc_ndev->mdev.dev);
make it even simpler! I would agree with the recommendation there.
Cheers,
Jeremy
next prev parent reply other threads:[~2024-12-18 0:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 18:25 [PATCH v9 0/1] MCTP Over PCC Transport admiyo
2024-12-17 18:25 ` [PATCH v9 1/1] mctp pcc: Implement MCTP over " admiyo
2024-12-17 19:04 ` Joe Damato
2024-12-18 0:09 ` Jeremy Kerr [this message]
2024-12-18 16:23 ` Adam Young
2024-12-18 18:17 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea0aac339c2ee7522510f1dab5f69a27413434d.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.