From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA69C6FD19 for ; Thu, 16 Mar 2023 07:45:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 950F185B90; Thu, 16 Mar 2023 08:45:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="X58S6aw+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5890D85C99; Thu, 16 Mar 2023 08:45:11 +0100 (CET) Received: from wrqvwxzv.outbound-mail.sendgrid.net (wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 754D185838 for ; Thu, 16 Mar 2023 08:45:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=mime-version:subject:references:from:in-reply-to:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=LgunNGle+NXUsH84g7IA3RLgqSlirLKikjMGhXsgQgs=; b=X58S6aw+knauMDtZPnxbW5n5/qWS4BaF7MgKny92o+x4grAExLUVC8d8PYFkRZKisWS3 irIvHPFOcst1QYbuST21WTHqRfCno/y6zBBeHluqsHMJvjK4LMG/p6QYZKICgP2gw9Hg6Q 7cxd5EER7pzE/YDQuMxkuTIWGyLNPsk9QaRYnqlQZI1vBQ89ocdZeHHd3/0+964KTi5Jte yMC7ohDpHo4GTZ8bzSeJpduyAxLMuoW0uNwvkmZahCnqiNHImhU7ZqgqFHzGhoo7l+tqvo n6N9ix4+w02WP2h/va1mA2q807n1225jU0BfTEE1+kzkCYB4/Ba3AcDrdHeOEFvg== Received: by filterdrecv-7946957d94-vscv5 with SMTP id filterdrecv-7946957d94-vscv5-1-6412C900-68 2023-03-16 07:45:04.532497581 +0000 UTC m=+1930284.112028240 Received: from [192.168.1.50] (unknown) by geopod-ismtpd-5 (SG) with ESMTP id 0qGh3W7WRhq12opddfc9Dg Thu, 16 Mar 2023 07:45:04.253 +0000 (UTC) Message-ID: <0ea3ef72-2c96-bc38-d4cf-55c15cd8be33@kwiboo.se> Date: Thu, 16 Mar 2023 07:45:04 +0000 (UTC) MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/9] binman: Show missing blob message when building U-Boot Content-Language: en-US References: <20230219220158.4160763-1-jonas@kwiboo.se> From: Jonas Karlman In-Reply-To: X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h4w7ZUE39sSqdukgc?= =?us-ascii?Q?EVYVob8ipO92z8Pd76KTc9TwQvUG5BPHEgzxEK5?= =?us-ascii?Q?5dL37hY0uAQGDb5=2FHACRFWFUnodNuSMvfBOo++d?= =?us-ascii?Q?exeLxaoiaR37i+N6aByWE46qJZqfUU5hV2sPfq+?= =?us-ascii?Q?DCRtW8w0pdczk8CpY8ayM=2F5iDV0NAJRtQ4GE1C?= To: Simon Glass Cc: Alper Nebi Yasak , Pali =?iso-8859-1?b?Um9o4XI=?= , Heinrich Schuchardt , Marek =?iso-8859-1?b?QmVo+m4=?= , Quentin Schulz , Stefan Herbrechtsmeier , u-boot@lists.denx.de X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 2023-03-10 21:49, Simon Glass wrote: > Hi Jonas, > > On Sun, 19 Feb 2023 at 14:02, Jonas Karlman wrote: >> >> binman currently support showing a helpful missing blob message, but >> only when the --allow-missing flag is used. >> >> This changes so that binman is invoked with the --allow-missing flag >> and the helpful message can be shown by default when building U-Boot. >> >> Using the following: >> >> make rockpro64-rk3399_defconfig >> make CROSS_COMPILE="aarch64-linux-gnu-" >> >> Before this series a build fails with: >> >> binman: Filename 'atf-bl31' not found in input path (...) >> >> After this series a build fails with: >> >> Image 'simple-bin' is missing external blobs and is non-functional: atf-bl31 >> >> /binman/simple-bin/fit/images/@atf-SEQ/atf-bl31 (atf-bl31): >> See the documentation for your board. You may need to build ARM Trusted >> Firmware and build with BL31=/path/to/bl31.bin >> >> Image 'simple-bin' is missing external blobs but is still functional: tee-os >> >> /binman/simple-bin/fit/images/@tee-SEQ/tee-os (tee-os): >> See the documentation for your board. You may need to build Open Portable >> Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin >> >> Some images are invalid >> >> Builds will continue to fail when there is missing blobs, and the use of >> BINMAN_ALLOW_MISSING=1 now only enables the --ignore-missing flag. >> >> This series also fixes a few minor issues that prevented some missing >> and optional blobs to be detected for fit and mkimage entries. >> >> Patch 1-3 contains spelling fixes and code cleanup for related parts. >> Patch 4-6 improve missing/optional detection for fit and mkimage entries. >> Patch 7-8 improve the missing blob warning message output. >> Patch 9 finally update Makefile to always pass the --allow-missing flag. >> >> The series is based on top of [1], and is the follow-up series meant to >> address the issue with missing blob message for mkimage entries. >> >> [1] https://patchwork.ozlabs.org/project/uboot/cover/20230219150629.4012377-1-jonas@kwiboo.se/ >> >> Jonas Karlman (9): >> binman: Remove redundant SetAllowFakeBlob from blob-ext entry >> binman: Fix spelling of nodes in code comments >> binman: Use correct argument name in docstrings >> binman: Override CheckOptional in fit entry >> binman: Implement missing check functions in mkimage entry >> binman: Mark mkimage entry missing when its subnodes is missing >> binman: Fix blank line usage for invalid images warning text >> binman: Show filename in missing blob help message >> Makefile: Show binman missing blob message >> >> Makefile | 2 +- >> tools/binman/control.py | 24 ++++++--- >> tools/binman/entry.py | 2 +- >> tools/binman/etype/blob.py | 2 +- >> tools/binman/etype/blob_ext.py | 8 --- >> tools/binman/etype/fit.py | 9 +++- >> tools/binman/etype/mkimage.py | 54 ++++++++++++++++++- >> tools/binman/etype/section.py | 6 +-- >> tools/binman/ftest.py | 9 ++++ >> tools/binman/state.py | 2 +- >> .../test/278_mkimage_missing_multiple.dts | 19 +++++++ >> 11 files changed, 111 insertions(+), 26 deletions(-) >> create mode 100644 tools/binman/test/278_mkimage_missing_multiple.dts >> >> -- >> 2.39.2 >> > > I applied what I could of this to -next > > Could you please take another look and see if we can get the rest in? Sure, I will take a look at a v2 (with more tests) in next few days. Still unclear what to do about "Makefile: Show binman missing blob message" at [2]. Should I re-send it as-is, change it or just drop it? [2] https://patchwork.ozlabs.org/project/uboot/patch/20230219220158.4160763-10-jonas@kwiboo.se/#3063614 Regards, Jonas > > Regards, > Simon