From: Thomas Huth <thuth@redhat.com>
To: Yodel Eldar <yodel.eldar@yodel.dev>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [RFC PATCH v2] configure: Use clang for sanitizer builds or disable Werror
Date: Tue, 3 Mar 2026 09:49:31 +0100 [thread overview]
Message-ID: <0eb9d64a-6663-466c-bc2f-8a614c5c7f8b@redhat.com> (raw)
In-Reply-To: <20260303012054.484837-1-yodel.eldar@yodel.dev>
On 03/03/2026 02.20, Yodel Eldar wrote:
> From: Yodel Eldar <yodel.eldar@yodel.dev>
>
> Builds with --enable-{asan,tsan,safe-stack} fail under GCC, so use
> clang if available, otherwise disable the treatment of warnings as
> errors.
That's already a very big change and might be rather confusing for the users
that expected configure to do something different.
If we really feel like we should silence this error in the old rtl8139 code,
I think we should do it locally there with some pragmas like this:
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wstringop-overflow"
... bad code ...
#pragma GCC diagnostic pop
WDYT?
Thomas
next prev parent reply other threads:[~2026-03-03 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 1:20 [RFC PATCH v2] configure: Use clang for sanitizer builds or disable Werror Yodel Eldar
2026-03-03 8:41 ` Daniel P. Berrangé
2026-03-03 9:36 ` Peter Maydell
2026-03-03 10:01 ` Daniel P. Berrangé
2026-03-03 10:05 ` Peter Maydell
2026-03-03 8:49 ` Thomas Huth [this message]
2026-03-04 1:08 ` Yodel Eldar
2026-03-04 7:38 ` Thomas Huth
2026-03-04 23:14 ` Yodel Eldar
2026-03-05 10:18 ` Daniel P. Berrangé
2026-03-05 10:47 ` Peter Maydell
2026-03-04 10:09 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eb9d64a-6663-466c-bc2f-8a614c5c7f8b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yodel.eldar@yodel.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.