All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'Chuck Lever'" <chuck.lever@oracle.com>, <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>
Subject: RE: [PATCH] Permit COMMIT operations to return NFS4_OK
Date: Fri, 4 Feb 2022 13:02:12 -0800	[thread overview]
Message-ID: <0ec101d81a0a$7bdfa880$739ef980$@mindspring.com> (raw)
In-Reply-To: <164400374422.1026143.17746475126462213720.stgit@morisot.1015granger.net>

> RFC 7530 permits COMMIT to return NFS4ERR_INVAL, but RFC 5661 and later do
> not. Allow INVAL as a legacy behavior, but test for OK also.

Do we have a 4.1 test to verify 4.1 and later doesn't return INVAL?

Frank

> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  nfs4.0/servertests/st_commit.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nfs4.0/servertests/st_commit.py b/nfs4.0/servertests/st_commit.py
> index 12a0dffa061f..4ef87e69c5d7 100644
> --- a/nfs4.0/servertests/st_commit.py
> +++ b/nfs4.0/servertests/st_commit.py
> @@ -160,4 +160,4 @@ def testCommitOverflow(t, env):
>      res = c.write_file(fh, _text, 0, stateid, how=UNSTABLE4)
>      check(res, msg="WRITE with how=UNSTABLE4")
>      res = c.commit_file(fh, 0xfffffffffffffff0, 64)
> -    check(res, NFS4ERR_INVAL, "COMMIT with offset + count overflow")
> +    check(res, [NFS4_OK, NFS4ERR_INVAL], "COMMIT with offset + count
> + overflow")



  reply	other threads:[~2022-02-04 21:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 19:42 [PATCH] Permit COMMIT operations to return NFS4_OK Chuck Lever
2022-02-04 21:02 ` Frank Filz [this message]
2022-02-04 21:06   ` Chuck Lever III
2022-02-04 21:11 ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0ec101d81a0a$7bdfa880$739ef980$@mindspring.com' \
    --to=ffilzlnx@mindspring.com \
    --cc=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.