All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 2/4] drm/xe/selftests: hold rpm for ccs_test_migrate()
Date: Thu, 13 Jul 2023 17:24:58 +0200	[thread overview]
Message-ID: <0ecbcc5f-ccb7-e39b-e0e8-40d844a95fed@linux.intel.com> (raw)
In-Reply-To: <20230713094125.326709-6-matthew.auld@intel.com>


On 7/13/2023 11:41 AM, Matthew Auld wrote:
> The GPU job will keep the device awake, however assumption here is that
> caller of xe_migrate_clear() is also holding mem_access.ref otherwise we
> hit the asserts in xe_sa_bo_flush_write() prior to the job construction.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/tests/xe_bo.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c b/drivers/gpu/drm/xe/tests/xe_bo.c
> index edee4116c59d..6aad1443b00e 100644
> --- a/drivers/gpu/drm/xe/tests/xe_bo.c
> +++ b/drivers/gpu/drm/xe/tests/xe_bo.c
> @@ -158,9 +158,15 @@ static int ccs_test_run_device(struct xe_device *xe)
>   		return 0;
>   	}
>   
> +	xe_pm_runtime_get(xe); /* FIXME: remove once mem_access actually works */
> +	xe_device_mem_access_get(xe);
> +
>   	for_each_gt(gt, xe, id)
>   		ccs_test_run_gt(xe, gt, test);
>   
> +	xe_device_mem_access_put(xe);
> +	xe_pm_runtime_put(xe);
> +
>   	return 0;
>   }
>   

  reply	other threads:[~2023-07-13 15:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  9:41 [Intel-xe] [PATCH 1/4] drm/xe/selftests: hold rpm for evict_test_run_device() Matthew Auld
2023-07-13  9:41 ` [Intel-xe] [PATCH 2/4] drm/xe/selftests: hold rpm for ccs_test_migrate() Matthew Auld
2023-07-13 15:24   ` Nirmoy Das [this message]
2023-07-13  9:41 ` [Intel-xe] [PATCH 3/4] drm/xe/selftests: restart GT after xe_bo_restore_kernel() Matthew Auld
2023-07-13 15:34   ` Nirmoy Das
2023-07-13  9:41 ` [Intel-xe] [PATCH 4/4] drm/xe: add missing bulk_move reset Matthew Auld
2023-07-13 16:05   ` Nirmoy Das
2023-07-14  9:02     ` Matthew Auld
2023-07-13 10:37 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/4] drm/xe/selftests: hold rpm for evict_test_run_device() Patchwork
2023-07-13 10:37 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-07-13 10:39 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-07-13 10:43 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-07-13 10:43 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-07-13 10:44 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-07-13 15:24 ` [Intel-xe] [PATCH 1/4] " Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ecbcc5f-ccb7-e39b-e0e8-40d844a95fed@linux.intel.com \
    --to=nirmoy.das@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.