From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D4B5C47422 for ; Fri, 26 Jan 2024 20:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FomvyWvGmGHsRZgUfnTEhi7BGqP+IcURaxQmpKtUUA0=; b=uzE4wBthCAatK2bW8Zwk1YxvKT 7I0mJ1CgbxwKM/NWcWpoNhPz9THGdOYg1en07n4jU+vffYCwrgvYilX4lZV6o9HU5g6tS/UM8YwFh wmr8S1nGZBV94qI7DP/5TIXyVeENGoTnCPmNeiO3yzuGBgBs2WQl3bjIjDrp+UXUqmKOdYOhBaZdh u/6+CNMhXN+85BoRZi+/T9nHFANJv8FL8AFY0ZQLdoe3Z3baJhhKzCG0s8u26Eb609mocT1HVNxby +sfA5Ii6/h4Qq5x4Q0y7+nCQtPlATSbrL8ULfUaMINcloUnSJnJExkazwiZ8yEjg7xsYIUyXFA53r avWpUfMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTSR2-00000005JiV-2IhN; Fri, 26 Jan 2024 20:04:20 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTSQy-00000005Jhh-31zk; Fri, 26 Jan 2024 20:04:18 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706299453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GSe9cmELggsROW8Xa3K0sEdzswCwt2lkxHp4I65nO1s=; b=i/lX5FaqbJSyzbAnEJyyaHyMOF4YfJwfmEhG3d7hPKYl5Gdati1LZW5uuDVPxyQm5GvoOB JQrwFbRDLuiKl/9c6olOazGw5ERUg/IQKZk9vb/GZhnHAnNVGGEUxNMqpi/k2vzTM3K9nx SwMQ0ipJknBOEbTbruAhcgqotsJkjWO8FjFj5biTohvmu3IBvwlSYngGrb7H6XwmpnFZqm tZlzcD4AGC/qI7jxs92HXlXo6ojYJrvUaXnDCOqfftK24KdQw3RTVAElogAJIyFiGvLhsZ e9T0SjMPoeI50YvU93d8zHFdNmArScFaon66WpNc0BIC+N2ZInwLyGLLs7tPbA== Date: Fri, 26 Jan 2024 21:04:12 +0100 From: Dragan Simic To: Daniel Lezcano Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Viresh Kumar Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 In-Reply-To: <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-4-5879275db36f@gmail.com> <731aac66-f698-4a1e-b9ee-46a7f24ecae5@linaro.org> <1f0608831cfb95c80edf16cd751eee76@manjaro.org> <528a37d84cdd871e717b4ebf648bb8a7@manjaro.org> <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> Message-ID: <0ed47e91c2d69ade447bd79bdfe5637a@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_120417_079152_BC53DF7B X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMS0yNiAxMzo1NiwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4gT24gMjYvMDEvMjAy NCAwODo0OSwgRHJhZ2FuIFNpbWljIHdyb3RlOgo+PiBPbiAyMDI0LTAxLTI2IDA4OjMwLCBBbGV4 ZXkgQ2hhcmtvdiB3cm90ZToKPj4+IE9uIEZyaSwgSmFuIDI2LCAyMDI0IGF0IDExOjA14oCvQU0g RHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+IAo+Pj4gd3JvdGU6Cj4+Pj4gT24gMjAy NC0wMS0yNiAwNzo0NCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+Pj4gPiBPbiBGcmksIEphbiAy NiwgMjAyNCBhdCAxMDozMuKAr0FNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPgo+ Pj4+ID4gd3JvdGU6Cj4+Pj4gPj4gT24gMjAyNC0wMS0yNSAxMDozMCwgRGFuaWVsIExlemNhbm8g d3JvdGU6Cj4+Pj4gPj4gPiBPbiAyNC8wMS8yMDI0IDIxOjMwLCBBbGV4ZXkgQ2hhcmtvdiB3cm90 ZToKPj4+PiA+PiA+PiBCeSBkZWZhdWx0IHRoZSBDUFVzIG9uIFJLMzU4OCBzdGFydCB1cCBpbiBh IGNvbnNlcnZhdGl2ZSBwZXJmb3JtYW5jZQo+Pj4+ID4+ID4+IG1vZGUuIEFkZCBmcmVxdWVuY3kg YW5kIHZvbHRhZ2UgbWFwcGluZ3MgdG8gdGhlIGRldmljZSB0cmVlIHRvIGVuYWJsZQo+IAo+IFsg Li4uIF0KPiAKPj4+IFRocm90dGxpbmcgd291bGQgYWxzbyBsb3dlciB0aGUgdm9sdGFnZSBhdCBz b21lIHBvaW50LCB3aGljaCBjb29scyBpdAo+Pj4gZG93biBtdWNoIGZhc3RlciEKPj4gCj4+IE9m IGNvdXJzZSwgYnV0IHRoZSBrZXkgaXMgbm90IHRvIGNvb2wgKGFuZCBzbG93IGRvd24pIHRoZSBD UFUgY29yZXMgCj4+IHRvbwo+PiBtdWNoLCBidXQganVzdCBlbm91Z2ggdG8gc3RheSB3aXRoaW4g dGhlIGF2YWlsYWJsZSB0aGVybWFsIGVudmVsb3BlLAo+PiB3aGljaCBpcyB3aGVyZSB0aGUgc2Ft ZS12b2x0YWdlLCBsb3dlci1mcmVxdWVuY3kgT1BQcyBzaG91bGQgc2hpbmUuCj4gCj4gVGhhdCBp bXBsaWVzIHRoZSByZXN1bHRpbmcgcG93ZXIgaXMgc3VzdGFpbmFibGUgd2hpY2ggSSBkb3VidCBp dCBpcyB0aGUgCj4gY2FzZS4KCkhtbSwgd2h5IHdvdWxkbid0IGl0IGJlIHN1c3RhaW5hYmxlPyAg V291bGQgeW91IGVsYWJvcmF0ZSBhIGJpdCwgcGxlYXNlPwpJIG1lYW4sIHRoZXJlIGFyZSBzbyBt YW55IGZhY3RvcnMgdGhhdCBjYW4ndCBiZSBrbm93biBmb3Igc3VyZSBpbiAKYWR2YW5jZSwKc28g cHJvdmlkaW5nIGFkZGl0aW9uYWwgQ1BVIHRocm90dGxpbmcgZ3JhbnVsYXJpdHkgY2FuIG9ubHkg YmUgaGVscGZ1bC4KCj4gVGhlIHZvbHRhZ2Ugc2NhbGluZyBtYWtlcyB0aGUgY29vbGluZyBlZmZl Y3QgZWZmaWNpZW50IG5vdCB0aGUgCj4gZnJlcXVlbmN5Lgo+IAo+IEZvciBleGFtcGxlOgo+IAlv cHA1ID0gb3BwKDJHSHosIDFWKSA9PiAyIEJvZ29XYXR0Cj4gCW9wcDQgPSBvcHAoMS45R0h6LCAx VikgPT4gMS45IEJvZ29XYXR0Cj4gCW9wcDMgPSBvcHAoMS44R0h6LCAwLjlWKSA9PiAxLjQ1OCBC b2dvV2F0dAo+IAlbIG90aGVyIHN0YXRlcyBidXQgd2UgZm9jdXMgb24gdGhlc2UgMyBdCj4gCj4g b3BwNS0+b3BwNCA9PiAtNSUgY29tcHV0ZSBjYXBhY2l0eSwgLTUlIHBvd2VyLCByYXRpbz0xCj4g b3BwNC0+b3BwMyA9PiAtNSUgY29tcHV0ZSBjYXBhY2l0eSwgLTIzLjElIHBvd2VyLCByYXRpbz0y MSw2Cj4gCj4gb3BwNS0+b3BwMyA9PiAtMTAlIGNvbXB1dGUgY2FwYWNpdHksIC0yNy4xJSBwb3dl ciwgcmF0aW89MzYuOQo+IAo+IEluIGJ1cnN0IG9wZXJhdGlvbiAobm8gdGhlcm1hbCB0aHJvdHRs aW5nKSwgb3BwNCBpcyBwb2ludGxlc3Mgd2UgYWdyZWUgCj4gb24gdGhhdC4KCldlbGwsIGlmIHRo ZXJlJ3Mgbm8gdGhlcm1hbCB0aHJvdHRpbmcgYXQgYWxsLCB0aGUgb3BwMyBpcyBhbHNvIG5vdApu ZWVkZWQuICBJbiBhbiB1bmxpa2VseSBzY2VuYXJpbyBsaWtlIHRoYXQsIHRoZSBvcHA1IGlzIGFs bCB3ZSBuZWVkLgoKPiBJTU8gdGhlIGZvbGxvd2luZyB3aWxsIGhhcHBlbjogaW4gYnVyc3Qgb3Bl cmF0aW9uIHdpdGggdGhlcm1hbAo+IHRocm90dGxpbmcgd2UgaGl0IHRoZSB0cmlwIHBvaW50IGFu ZCB0aGVuIHRoZSBzdGVwIHdpc2UgZ292ZXJub3IKPiByZWR1Y2VzIG9wcDUgLT4gb3BwNC4gV2Ug aGF2ZSBzbGlnaHQgcG93ZXIgcmVkdWN0aW9uIGJ1dCB0aGUKPiB0ZW1wZXJhdHVyZSBkb2VzIG5v dCBkZWNyZWFzZSwgc28gYXQgdGhlIG5leHQgaXRlcmF0aW9uLCBpdCBpcwo+IHRocm90dGxlIGF0 IG9wcDMuIEFuZCBhdCB0aGUgZW5kIHdlIGhhdmUgb3BwNCA8LT4gb3BwMyBiYWNrIGFuZCBmb3J0 aAo+IGluc3RlYWQgb2Ygb3BwNSA8LT4gb3BwMy4KCldoeSBzaG91bGQgdGhlIHRlbXBlcmF0dXJl IG5vdCBkZWNyZWFzZSB3aGVuIHN3aXRjaGluZyBmcm9tIHRoZSBvcHA1CnRvIHRoZSBvcHA0PyAg U2VlLCB3ZSBjYW4ndCBhc3N1bWUgb3Iga25vdyBpbiBhZHZhbmNlIHRoYXQgcmVkdWNpbmcKdGhl IHBvd2VyIGNvbnN1bXB0aW9uIGJ5IDUlIHdvdWxkbid0IGRvIGFueXRoaW5nOyAgNSUgaXMgYWN0 dWFsbHkKcXVpdGUgYSBsb3QuICBJZiB0aGF0IHdvdWxkIGRvIGFic29sdXRlbHkgbm90aGluZywg dGhlbiBzb21ldGhpbmcKZWxzZSB3b3VsZCBwcm9iYWJseSBiZSB3cm9uZyBvciBub3QgYXMgZXhw ZWN0ZWQuCgpBbHNvLCBmb3Igc29tZSB3b3JrbG9hZHMgaXQgbWlnaHQgYmUgYmV0dGVyIHRvIGhh dmUgcmF0aGVyIGZyZXF1ZW50CnRyYW5zaXRpb25zIGJldHdlZW4gdGhlIG9wcDQgYW5kIHRoZSBv cHAzLCBpbnN0ZWFkIG9mIHN0YXlpbmcgYXQgdGhlCm9wcDMgZm9yIGxvbmdlciBwcmlvZHMgb2Yg dGltZS4gIFJ1bm5pbmcgMTAwIE1IeiBmYXN0ZXIgY2FuIGJlIHF1aXRlCnNpZ25pZmljYW50LCBl c3BlY2lhbGx5IG9uIHR3byBDUFUgY29yZXMuCgo+IEl0IGlzIHByb2JhYmxlIHdlIGVuZCB1cCB3 aXRoIGFuIGVxdWl2YWxlbnQgZnJlcXVlbmN5IGF2ZXJhZ2UgKG9yCj4gY29tcHV0ZSBjYXBhY2l0 eSBhdmcpLgo+IAo+IG9wcDQgPC0+IG9wcDMgKGxvbmdlciBkdXJhdGlvbiBpbiBzdGF0ZXMsIGxl c3MgdHJhbnNpdGlvbnMpCj4gb3BwNSA8LT4gb3BwMyAoc2hvcnRlciBkdXJhdGlvbiBpbiBzdGF0 ZXMsIG1vcmUgdHJhbnNpdGlvbnMpCj4gCj4gU29tZSBwbGF0Zm9ybXMgaGFkIHRoZWlyIGhpZ2hl ciBPUFBzIHdpdGggdGhlIHNhbWUgdm9sdGFnZSBhbmQgdGhleQo+IGZhaWxlZCB0byBjb29sIGRv d24gdGhlIENQVSBpbiB0aGUgbG9uZyBydW4uCj4gCj4gQW55d2F5LCB0aGVyZSBpcyBvbmx5IG9u ZSB3YXkgdG8gY2hlY2sgaXQgb3V0IDopCj4gCj4gQWxleGV5LCBpcyBpdCBwb3NzaWJsZSB0byBj b21wYXJlIHRoZSBjb21wdXRlIGR1cmF0aW9uIGZvciAnZGhyeXN0b25lJwo+IHdpdGggdGhlc2Ug dm9sdGFnZSBPUFAgYW5kIHdpdGhvdXQgPyAod2l0aCBhIHBlcmlvZCBvZiBjb29sIGRvd24KPiBi ZXR3ZWVuIHRoZSB0ZXN0IGluIG9yZGVyIHRvIHN0YXJ0IGF0IHRoZSBzYW1lIHRoZXJtYWwgY29u ZGl0aW9uKSA/CgpJIGFncmVlIHRoYXQgdGVzdGluZyBhbmQgcmVjb3JkaW5nIGFzIG11Y2ggZGF0 YSBhcyBwb3NzaWJsZSBpcyB0aGUgYmVzdAphcHByb2FjaC4gIEhvd2V2ZXIsIHF1aXRlIGZyYW5r bHksIHdlIHNob3VsZCBydW4gbW9yZSBkaWZmZXJlbnQgdGVzdHMsCm5vdCBvbmx5IG9uZSBzeW50 aGV0aWMgdGVzdC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0C67C47DDB for ; Fri, 26 Jan 2024 20:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ALgFkQ6mg8XJn83FGq1ZmLPtLoUW2ueA+xkWVkgLEU=; b=O15NKpUK+x0htcOPD4FVVw6stR 1YoW+fl1Jt71LyepnfvJz8b3OcddW181PANFaoVWiGDgFn16FDlAxMQNQ5yfRWx495C1QWe6KNWJE TGUNHDUoKHtMas8o3zZp5EtpNbZpmPkswZ17PKGiAUrfZAwCxLP9ZTdBy9M/z1aLmDXbW6VZkZoKH mOFLe2K+1TgL75vUzXR8u3+rVMPTTKrLRBpdXtf2WcepvF+UC+lldmpxiv5Jl7L4UHolU7BGeyjJO FDyGKLRzEZQKn9aaDRbQCnMFCs/g0RserGxkK5vXLPi2tVkwtykfZUIHhVrHLSOYvk3gDcrN1oBWt uanTTsCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTSR1-00000005JiC-4AqV; Fri, 26 Jan 2024 20:04:19 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTSQy-00000005Jhh-31zk; Fri, 26 Jan 2024 20:04:18 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706299453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GSe9cmELggsROW8Xa3K0sEdzswCwt2lkxHp4I65nO1s=; b=i/lX5FaqbJSyzbAnEJyyaHyMOF4YfJwfmEhG3d7hPKYl5Gdati1LZW5uuDVPxyQm5GvoOB JQrwFbRDLuiKl/9c6olOazGw5ERUg/IQKZk9vb/GZhnHAnNVGGEUxNMqpi/k2vzTM3K9nx SwMQ0ipJknBOEbTbruAhcgqotsJkjWO8FjFj5biTohvmu3IBvwlSYngGrb7H6XwmpnFZqm tZlzcD4AGC/qI7jxs92HXlXo6ojYJrvUaXnDCOqfftK24KdQw3RTVAElogAJIyFiGvLhsZ e9T0SjMPoeI50YvU93d8zHFdNmArScFaon66WpNc0BIC+N2ZInwLyGLLs7tPbA== Date: Fri, 26 Jan 2024 21:04:12 +0100 From: Dragan Simic To: Daniel Lezcano Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Viresh Kumar Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 In-Reply-To: <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-4-5879275db36f@gmail.com> <731aac66-f698-4a1e-b9ee-46a7f24ecae5@linaro.org> <1f0608831cfb95c80edf16cd751eee76@manjaro.org> <528a37d84cdd871e717b4ebf648bb8a7@manjaro.org> <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> Message-ID: <0ed47e91c2d69ade447bd79bdfe5637a@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_120417_079152_BC53DF7B X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMS0yNiAxMzo1NiwgRGFuaWVsIExlemNhbm8gd3JvdGU6Cj4gT24gMjYvMDEvMjAy NCAwODo0OSwgRHJhZ2FuIFNpbWljIHdyb3RlOgo+PiBPbiAyMDI0LTAxLTI2IDA4OjMwLCBBbGV4 ZXkgQ2hhcmtvdiB3cm90ZToKPj4+IE9uIEZyaSwgSmFuIDI2LCAyMDI0IGF0IDExOjA14oCvQU0g RHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+IAo+Pj4gd3JvdGU6Cj4+Pj4gT24gMjAy NC0wMS0yNiAwNzo0NCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+Pj4gPiBPbiBGcmksIEphbiAy NiwgMjAyNCBhdCAxMDozMuKAr0FNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPgo+ Pj4+ID4gd3JvdGU6Cj4+Pj4gPj4gT24gMjAyNC0wMS0yNSAxMDozMCwgRGFuaWVsIExlemNhbm8g d3JvdGU6Cj4+Pj4gPj4gPiBPbiAyNC8wMS8yMDI0IDIxOjMwLCBBbGV4ZXkgQ2hhcmtvdiB3cm90 ZToKPj4+PiA+PiA+PiBCeSBkZWZhdWx0IHRoZSBDUFVzIG9uIFJLMzU4OCBzdGFydCB1cCBpbiBh IGNvbnNlcnZhdGl2ZSBwZXJmb3JtYW5jZQo+Pj4+ID4+ID4+IG1vZGUuIEFkZCBmcmVxdWVuY3kg YW5kIHZvbHRhZ2UgbWFwcGluZ3MgdG8gdGhlIGRldmljZSB0cmVlIHRvIGVuYWJsZQo+IAo+IFsg Li4uIF0KPiAKPj4+IFRocm90dGxpbmcgd291bGQgYWxzbyBsb3dlciB0aGUgdm9sdGFnZSBhdCBz b21lIHBvaW50LCB3aGljaCBjb29scyBpdAo+Pj4gZG93biBtdWNoIGZhc3RlciEKPj4gCj4+IE9m IGNvdXJzZSwgYnV0IHRoZSBrZXkgaXMgbm90IHRvIGNvb2wgKGFuZCBzbG93IGRvd24pIHRoZSBD UFUgY29yZXMgCj4+IHRvbwo+PiBtdWNoLCBidXQganVzdCBlbm91Z2ggdG8gc3RheSB3aXRoaW4g dGhlIGF2YWlsYWJsZSB0aGVybWFsIGVudmVsb3BlLAo+PiB3aGljaCBpcyB3aGVyZSB0aGUgc2Ft ZS12b2x0YWdlLCBsb3dlci1mcmVxdWVuY3kgT1BQcyBzaG91bGQgc2hpbmUuCj4gCj4gVGhhdCBp bXBsaWVzIHRoZSByZXN1bHRpbmcgcG93ZXIgaXMgc3VzdGFpbmFibGUgd2hpY2ggSSBkb3VidCBp dCBpcyB0aGUgCj4gY2FzZS4KCkhtbSwgd2h5IHdvdWxkbid0IGl0IGJlIHN1c3RhaW5hYmxlPyAg V291bGQgeW91IGVsYWJvcmF0ZSBhIGJpdCwgcGxlYXNlPwpJIG1lYW4sIHRoZXJlIGFyZSBzbyBt YW55IGZhY3RvcnMgdGhhdCBjYW4ndCBiZSBrbm93biBmb3Igc3VyZSBpbiAKYWR2YW5jZSwKc28g cHJvdmlkaW5nIGFkZGl0aW9uYWwgQ1BVIHRocm90dGxpbmcgZ3JhbnVsYXJpdHkgY2FuIG9ubHkg YmUgaGVscGZ1bC4KCj4gVGhlIHZvbHRhZ2Ugc2NhbGluZyBtYWtlcyB0aGUgY29vbGluZyBlZmZl Y3QgZWZmaWNpZW50IG5vdCB0aGUgCj4gZnJlcXVlbmN5Lgo+IAo+IEZvciBleGFtcGxlOgo+IAlv cHA1ID0gb3BwKDJHSHosIDFWKSA9PiAyIEJvZ29XYXR0Cj4gCW9wcDQgPSBvcHAoMS45R0h6LCAx VikgPT4gMS45IEJvZ29XYXR0Cj4gCW9wcDMgPSBvcHAoMS44R0h6LCAwLjlWKSA9PiAxLjQ1OCBC b2dvV2F0dAo+IAlbIG90aGVyIHN0YXRlcyBidXQgd2UgZm9jdXMgb24gdGhlc2UgMyBdCj4gCj4g b3BwNS0+b3BwNCA9PiAtNSUgY29tcHV0ZSBjYXBhY2l0eSwgLTUlIHBvd2VyLCByYXRpbz0xCj4g b3BwNC0+b3BwMyA9PiAtNSUgY29tcHV0ZSBjYXBhY2l0eSwgLTIzLjElIHBvd2VyLCByYXRpbz0y MSw2Cj4gCj4gb3BwNS0+b3BwMyA9PiAtMTAlIGNvbXB1dGUgY2FwYWNpdHksIC0yNy4xJSBwb3dl ciwgcmF0aW89MzYuOQo+IAo+IEluIGJ1cnN0IG9wZXJhdGlvbiAobm8gdGhlcm1hbCB0aHJvdHRs aW5nKSwgb3BwNCBpcyBwb2ludGxlc3Mgd2UgYWdyZWUgCj4gb24gdGhhdC4KCldlbGwsIGlmIHRo ZXJlJ3Mgbm8gdGhlcm1hbCB0aHJvdHRpbmcgYXQgYWxsLCB0aGUgb3BwMyBpcyBhbHNvIG5vdApu ZWVkZWQuICBJbiBhbiB1bmxpa2VseSBzY2VuYXJpbyBsaWtlIHRoYXQsIHRoZSBvcHA1IGlzIGFs bCB3ZSBuZWVkLgoKPiBJTU8gdGhlIGZvbGxvd2luZyB3aWxsIGhhcHBlbjogaW4gYnVyc3Qgb3Bl cmF0aW9uIHdpdGggdGhlcm1hbAo+IHRocm90dGxpbmcgd2UgaGl0IHRoZSB0cmlwIHBvaW50IGFu ZCB0aGVuIHRoZSBzdGVwIHdpc2UgZ292ZXJub3IKPiByZWR1Y2VzIG9wcDUgLT4gb3BwNC4gV2Ug aGF2ZSBzbGlnaHQgcG93ZXIgcmVkdWN0aW9uIGJ1dCB0aGUKPiB0ZW1wZXJhdHVyZSBkb2VzIG5v dCBkZWNyZWFzZSwgc28gYXQgdGhlIG5leHQgaXRlcmF0aW9uLCBpdCBpcwo+IHRocm90dGxlIGF0 IG9wcDMuIEFuZCBhdCB0aGUgZW5kIHdlIGhhdmUgb3BwNCA8LT4gb3BwMyBiYWNrIGFuZCBmb3J0 aAo+IGluc3RlYWQgb2Ygb3BwNSA8LT4gb3BwMy4KCldoeSBzaG91bGQgdGhlIHRlbXBlcmF0dXJl IG5vdCBkZWNyZWFzZSB3aGVuIHN3aXRjaGluZyBmcm9tIHRoZSBvcHA1CnRvIHRoZSBvcHA0PyAg U2VlLCB3ZSBjYW4ndCBhc3N1bWUgb3Iga25vdyBpbiBhZHZhbmNlIHRoYXQgcmVkdWNpbmcKdGhl IHBvd2VyIGNvbnN1bXB0aW9uIGJ5IDUlIHdvdWxkbid0IGRvIGFueXRoaW5nOyAgNSUgaXMgYWN0 dWFsbHkKcXVpdGUgYSBsb3QuICBJZiB0aGF0IHdvdWxkIGRvIGFic29sdXRlbHkgbm90aGluZywg dGhlbiBzb21ldGhpbmcKZWxzZSB3b3VsZCBwcm9iYWJseSBiZSB3cm9uZyBvciBub3QgYXMgZXhw ZWN0ZWQuCgpBbHNvLCBmb3Igc29tZSB3b3JrbG9hZHMgaXQgbWlnaHQgYmUgYmV0dGVyIHRvIGhh dmUgcmF0aGVyIGZyZXF1ZW50CnRyYW5zaXRpb25zIGJldHdlZW4gdGhlIG9wcDQgYW5kIHRoZSBv cHAzLCBpbnN0ZWFkIG9mIHN0YXlpbmcgYXQgdGhlCm9wcDMgZm9yIGxvbmdlciBwcmlvZHMgb2Yg dGltZS4gIFJ1bm5pbmcgMTAwIE1IeiBmYXN0ZXIgY2FuIGJlIHF1aXRlCnNpZ25pZmljYW50LCBl c3BlY2lhbGx5IG9uIHR3byBDUFUgY29yZXMuCgo+IEl0IGlzIHByb2JhYmxlIHdlIGVuZCB1cCB3 aXRoIGFuIGVxdWl2YWxlbnQgZnJlcXVlbmN5IGF2ZXJhZ2UgKG9yCj4gY29tcHV0ZSBjYXBhY2l0 eSBhdmcpLgo+IAo+IG9wcDQgPC0+IG9wcDMgKGxvbmdlciBkdXJhdGlvbiBpbiBzdGF0ZXMsIGxl c3MgdHJhbnNpdGlvbnMpCj4gb3BwNSA8LT4gb3BwMyAoc2hvcnRlciBkdXJhdGlvbiBpbiBzdGF0 ZXMsIG1vcmUgdHJhbnNpdGlvbnMpCj4gCj4gU29tZSBwbGF0Zm9ybXMgaGFkIHRoZWlyIGhpZ2hl ciBPUFBzIHdpdGggdGhlIHNhbWUgdm9sdGFnZSBhbmQgdGhleQo+IGZhaWxlZCB0byBjb29sIGRv d24gdGhlIENQVSBpbiB0aGUgbG9uZyBydW4uCj4gCj4gQW55d2F5LCB0aGVyZSBpcyBvbmx5IG9u ZSB3YXkgdG8gY2hlY2sgaXQgb3V0IDopCj4gCj4gQWxleGV5LCBpcyBpdCBwb3NzaWJsZSB0byBj b21wYXJlIHRoZSBjb21wdXRlIGR1cmF0aW9uIGZvciAnZGhyeXN0b25lJwo+IHdpdGggdGhlc2Ug dm9sdGFnZSBPUFAgYW5kIHdpdGhvdXQgPyAod2l0aCBhIHBlcmlvZCBvZiBjb29sIGRvd24KPiBi ZXR3ZWVuIHRoZSB0ZXN0IGluIG9yZGVyIHRvIHN0YXJ0IGF0IHRoZSBzYW1lIHRoZXJtYWwgY29u ZGl0aW9uKSA/CgpJIGFncmVlIHRoYXQgdGVzdGluZyBhbmQgcmVjb3JkaW5nIGFzIG11Y2ggZGF0 YSBhcyBwb3NzaWJsZSBpcyB0aGUgYmVzdAphcHByb2FjaC4gIEhvd2V2ZXIsIHF1aXRlIGZyYW5r bHksIHdlIHNob3VsZCBydW4gbW9yZSBkaWZmZXJlbnQgdGVzdHMsCm5vdCBvbmx5IG9uZSBzeW50 aGV0aWMgdGVzdC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D3622616; Fri, 26 Jan 2024 20:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706299459; cv=none; b=ijig1lA91DuTJNt7Rn1YXrfigMuRP1jmzv8htRGl8vOfXQFoqc76AvE0/8eJGUU6Qa7r5V6u2wzzjvmHFzD898FqKSuNmooV/Y6Sle2grxpJRgh1XQtyALd/CFMSWLfe8mpXK94Di5oe4Wwutk0fYPnhadYnrnxEx8yr+0eFzvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706299459; c=relaxed/simple; bh=WpeuBB6OF2cH1n6dbWfQ48jzm0zZaAYZoCRX4MyWQ8E=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=gXlxDSnTFQc29ndFquweFIGKlhS0Z9eeczmfV7htn4RCVHcWqac1pmsWXQcYBSPrK/ooE+SPyH9NlRzbTARbGQHYmpgSLCp2lZyel5pFUQYhGMBC0gmueJSMYuP33d3o5cQp25/m3j+bOhV95hisVoYARPH4QIbmOQKj8ako9cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=i/lX5Faq; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="i/lX5Faq" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1706299453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GSe9cmELggsROW8Xa3K0sEdzswCwt2lkxHp4I65nO1s=; b=i/lX5FaqbJSyzbAnEJyyaHyMOF4YfJwfmEhG3d7hPKYl5Gdati1LZW5uuDVPxyQm5GvoOB JQrwFbRDLuiKl/9c6olOazGw5ERUg/IQKZk9vb/GZhnHAnNVGGEUxNMqpi/k2vzTM3K9nx SwMQ0ipJknBOEbTbruAhcgqotsJkjWO8FjFj5biTohvmu3IBvwlSYngGrb7H6XwmpnFZqm tZlzcD4AGC/qI7jxs92HXlXo6ojYJrvUaXnDCOqfftK24KdQw3RTVAElogAJIyFiGvLhsZ e9T0SjMPoeI50YvU93d8zHFdNmArScFaon66WpNc0BIC+N2ZInwLyGLLs7tPbA== Date: Fri, 26 Jan 2024 21:04:12 +0100 From: Dragan Simic To: Daniel Lezcano Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Viresh Kumar Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 In-Reply-To: <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> References: <20240125-rk-dts-additions-v1-0-5879275db36f@gmail.com> <20240125-rk-dts-additions-v1-4-5879275db36f@gmail.com> <731aac66-f698-4a1e-b9ee-46a7f24ecae5@linaro.org> <1f0608831cfb95c80edf16cd751eee76@manjaro.org> <528a37d84cdd871e717b4ebf648bb8a7@manjaro.org> <9b72b688-be63-464e-a5dc-cf6051ccee12@linaro.org> Message-ID: <0ed47e91c2d69ade447bd79bdfe5637a@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-01-26 13:56, Daniel Lezcano wrote: > On 26/01/2024 08:49, Dragan Simic wrote: >> On 2024-01-26 08:30, Alexey Charkov wrote: >>> On Fri, Jan 26, 2024 at 11:05 AM Dragan Simic >>> wrote: >>>> On 2024-01-26 07:44, Alexey Charkov wrote: >>>> > On Fri, Jan 26, 2024 at 10:32 AM Dragan Simic >>>> > wrote: >>>> >> On 2024-01-25 10:30, Daniel Lezcano wrote: >>>> >> > On 24/01/2024 21:30, Alexey Charkov wrote: >>>> >> >> By default the CPUs on RK3588 start up in a conservative performance >>>> >> >> mode. Add frequency and voltage mappings to the device tree to enable > > [ ... ] > >>> Throttling would also lower the voltage at some point, which cools it >>> down much faster! >> >> Of course, but the key is not to cool (and slow down) the CPU cores >> too >> much, but just enough to stay within the available thermal envelope, >> which is where the same-voltage, lower-frequency OPPs should shine. > > That implies the resulting power is sustainable which I doubt it is the > case. Hmm, why wouldn't it be sustainable? Would you elaborate a bit, please? I mean, there are so many factors that can't be known for sure in advance, so providing additional CPU throttling granularity can only be helpful. > The voltage scaling makes the cooling effect efficient not the > frequency. > > For example: > opp5 = opp(2GHz, 1V) => 2 BogoWatt > opp4 = opp(1.9GHz, 1V) => 1.9 BogoWatt > opp3 = opp(1.8GHz, 0.9V) => 1.458 BogoWatt > [ other states but we focus on these 3 ] > > opp5->opp4 => -5% compute capacity, -5% power, ratio=1 > opp4->opp3 => -5% compute capacity, -23.1% power, ratio=21,6 > > opp5->opp3 => -10% compute capacity, -27.1% power, ratio=36.9 > > In burst operation (no thermal throttling), opp4 is pointless we agree > on that. Well, if there's no thermal throtting at all, the opp3 is also not needed. In an unlikely scenario like that, the opp5 is all we need. > IMO the following will happen: in burst operation with thermal > throttling we hit the trip point and then the step wise governor > reduces opp5 -> opp4. We have slight power reduction but the > temperature does not decrease, so at the next iteration, it is > throttle at opp3. And at the end we have opp4 <-> opp3 back and forth > instead of opp5 <-> opp3. Why should the temperature not decrease when switching from the opp5 to the opp4? See, we can't assume or know in advance that reducing the power consumption by 5% wouldn't do anything; 5% is actually quite a lot. If that would do absolutely nothing, then something else would probably be wrong or not as expected. Also, for some workloads it might be better to have rather frequent transitions between the opp4 and the opp3, instead of staying at the opp3 for longer priods of time. Running 100 MHz faster can be quite significant, especially on two CPU cores. > It is probable we end up with an equivalent frequency average (or > compute capacity avg). > > opp4 <-> opp3 (longer duration in states, less transitions) > opp5 <-> opp3 (shorter duration in states, more transitions) > > Some platforms had their higher OPPs with the same voltage and they > failed to cool down the CPU in the long run. > > Anyway, there is only one way to check it out :) > > Alexey, is it possible to compare the compute duration for 'dhrystone' > with these voltage OPP and without ? (with a period of cool down > between the test in order to start at the same thermal condition) ? I agree that testing and recording as much data as possible is the best approach. However, quite frankly, we should run more different tests, not only one synthetic test.