From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB04C56201 for ; Wed, 21 Oct 2020 07:29:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19C7D22453 for ; Wed, 21 Oct 2020 07:29:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="LfS7il7i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407717AbgJUH3j (ORCPT ); Wed, 21 Oct 2020 03:29:39 -0400 Received: from z5.mailgun.us ([104.130.96.5]:62495 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407734AbgJUH3j (ORCPT ); Wed, 21 Oct 2020 03:29:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603265378; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=C02hDgWV8WL/Mgowwhjuc5XmmX/v8fdfGLciqHxcx6w=; b=LfS7il7i4isPqRB6kmZ3KNOWjUYuI+lDXx1LlYlzipUF34gGeslMP+qeZ/Du9lHQp45npW9l igGwCk1YaiKtIODPf8xCSoNlR9Buy+blbe7XlQMKntJxuIGkMccOaa/JX6UgMvwBUZV2tKHT uvzBr+6PEG4/54cOnezPAc0dmIo= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5f8fe361bfed2afaa6722297 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 21 Oct 2020 07:29:37 GMT Sender: saiprakash.ranjan=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 68022C43385; Wed, 21 Oct 2020 07:29:36 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7E393C433CB; Wed, 21 Oct 2020 07:29:35 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 21 Oct 2020 12:59:35 +0530 From: Sai Prakash Ranjan To: Suzuki K Poulose , Mathieu Poirier Cc: mike.leach@linaro.org, coresight@lists.linaro.org, swboyd@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, denik@google.com, leo.yan@linaro.org, peterz@infradead.org Subject: Re: [PATCH 1/2] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf() In-Reply-To: <8affc09d4045812e2f5a065695b375de@codeaurora.org> References: <5bbb2d35-3e56-56d7-4722-bf34c5efa2fb@arm.com> <9fa4fcc25dac17b343d151a9d089b48c@codeaurora.org> <707b7860-0daa-d3e3-1f0f-17e1b05feae2@arm.com> <5ad6acdc69c1c2e1e17f5c701a09b7e1@codeaurora.org> <8affc09d4045812e2f5a065695b375de@codeaurora.org> Message-ID: <0ee3566e50143bac5b662b2edf551b89@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-10-20 21:40, Sai Prakash Ranjan wrote: > On 2020-10-14 21:29, Sai Prakash Ranjan wrote: >> On 2020-10-14 18:46, Suzuki K Poulose wrote: >>> On 10/14/2020 10:36 AM, Sai Prakash Ranjan wrote: >>>> On 2020-10-13 22:05, Suzuki K Poulose wrote: >>>>> On 10/07/2020 02:00 PM, Sai Prakash Ranjan wrote: >>>>>> There was a report of NULL pointer dereference in ETF enable >>>>>> path for perf CS mode with PID monitoring. It is almost 100% >>>>>> reproducible when the process to monitor is something very >>>>>> active such as chrome and with ETF as the sink and not ETR. >>>>>> Currently in a bid to find the pid, the owner is dereferenced >>>>>> via task_pid_nr() call in tmc_enable_etf_sink_perf() and with >>>>>> owner being NULL, we get a NULL pointer dereference. >>>>>> >>>>>> Looking at the ETR and other places in the kernel, ETF and the >>>>>> ETB are the only places trying to dereference the task(owner) >>>>>> in tmc_enable_etf_sink_perf() which is also called from the >>>>>> sched_in path as in the call trace. Owner(task) is NULL even >>>>>> in the case of ETR in tmc_enable_etr_sink_perf(), but since we >>>>>> cache the PID in alloc_buffer() callback and it is done as part >>>>>> of etm_setup_aux() when allocating buffer for ETR sink, we never >>>>>> dereference this NULL pointer and we are safe. So lets do the >>>>> >>>>> The patch is necessary to fix some of the issues. But I feel it is >>>>> not complete. Why is it safe earlier and not later ? I believe we >>>>> are >>>>> simply reducing the chances of hitting the issue, by doing this >>>>> earlier than >>>>> later. I would say we better fix all instances to make sure that >>>>> the >>>>> event->owner is valid. (e.g, I can see that the for kernel events >>>>> event->owner == -1 ?) >>>>> >>>>> struct task_struct *tsk = READ_ONCE(event->owner); >>>>> >>>>> if (!tsk || is_kernel_event(event)) >>>>>    /* skip ? */ >>>>> >>>> >>>> Looking at it some more, is_kernel_event() is not exposed >>>> outside events core and probably for good reason. Why do >>>> we need to check for this and not just tsk? >>> >>> Because the event->owner could be : >>> >>> = NULL >>> = -1UL // kernel event >>> = valid. >>> >> >> Yes I understood that part, but here we were trying to >> fix the NULL pointer dereference right and hence the >> question as to why we need to check for kernel events? >> I am no expert in perf but I don't see anywhere in the >> kernel checking for is_kernel_event(), so I am a bit >> skeptical if exporting that is actually right or not. >> > > I have stress tested with the original patch many times > now, i.e., without a check for event->owner and is_kernel_event() > and didn't observe any crash. Plus on ETR where this was already > done, no crashes were reported till date and with ETF, the issue > was quickly reproducible, so I am fairly confident that this > doesn't just delay the original issue but actually fixes > it. I will run an overnight test again to confirm this. > I ran the overnight test which collected aroung 4G data(see below), with the following small change to see if the two cases (event->owner=NULL and is_kernel_event()) are triggered with suggested changes and it didn't trigger at all. Do we still need those additional checks? [ perf record: Captured and wrote 4677.989 MB perf.data ] diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c index 989d965f3d90..123c446ce585 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c @@ -13,6 +13,13 @@ #include "coresight-tmc.h" #include "coresight-etm-perf.h" +#define TASK_TOMBSTONE ((void *)-1L) + +static bool is_kernel_event2(struct perf_event *event) +{ + return READ_ONCE(event->owner) == TASK_TOMBSTONE; +} + static int tmc_set_etf_buffer(struct coresight_device *csdev, struct perf_output_handle *handle); @@ -392,6 +399,15 @@ static void *tmc_alloc_etf_buffer(struct coresight_device *csdev, { int node; struct cs_buffers *buf; + struct task_struct *task = READ_ONCE(event->owner); + + if (!task) { + pr_info("**sai in task=NULL**\n"); + return NULL; + } + + if (is_kernel_event2(event)) + pr_info("**sai in is_kernel_event**\n"); node = (event->cpu == -1) ? NUMA_NO_NODE : cpu_to_node(event->cpu); Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B860C561F8 for ; Wed, 21 Oct 2020 07:31:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AE2122251 for ; Wed, 21 Oct 2020 07:31:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aehVpeTo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="uy0C40TB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AE2122251 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YdjCe84R456mC1KZVQAHWIdh1mCWtuxiWXkXyvcyQLM=; b=aehVpeToGMliUbqn/vPFYFGoJ Zgc8XVSjKuJFEwfRA6O04Ucc8yirJaFnqGFwUB4ESo6OouTjNK4dNXRleIXLO+qmGQAZMngjmg6po Gac+ydkbTtzY68mCr8fkZVk0oBeTDDDmyhzkUdza8V100ln1xydFK2YVvYJLWYiFOJ+YXSqhhnBNp nE7bEKmvCT4cGL8csL5xhAjEZ+uO+nfa7yAkzz5tFSD9i+831aoOqkY3AYuHo+7+rS1ZUIa7yeL6l h82o1CiGNwWGTRk7jb+40IyOkGc4nJcMYnME1CxwTAKvdxJpd/BxpGYpbSVYmV3zkvmrzsLFgr9k5 7Z6NbiYcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kV8Z3-0001BM-QT; Wed, 21 Oct 2020 07:29:41 +0000 Received: from m42-4.mailgun.net ([69.72.42.4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kV8Z1-0001AG-3i for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 07:29:40 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603265379; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=C02hDgWV8WL/Mgowwhjuc5XmmX/v8fdfGLciqHxcx6w=; b=uy0C40TBRJdPJYDqbQ45DyA8+W8sMc1i+61Xhc6F2oO3IB+Bem7pVPxnHvO8U3TsHhfbU1u/ lFgFw8WG2w7SXlGpm8pxxS4TXm1JhuJ5d4MSv//NfTclNeHZfHIAjS8p6rOiQo9eGMvysjJF MNtSnSbcUMsNd/AaTVK5hhYWGDE= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5f8fe36042f9861fb17ee169 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 21 Oct 2020 07:29:36 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 58492C43382; Wed, 21 Oct 2020 07:29:36 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7E393C433CB; Wed, 21 Oct 2020 07:29:35 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 21 Oct 2020 12:59:35 +0530 From: Sai Prakash Ranjan To: Suzuki K Poulose , Mathieu Poirier Subject: Re: [PATCH 1/2] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf() In-Reply-To: <8affc09d4045812e2f5a065695b375de@codeaurora.org> References: <5bbb2d35-3e56-56d7-4722-bf34c5efa2fb@arm.com> <9fa4fcc25dac17b343d151a9d089b48c@codeaurora.org> <707b7860-0daa-d3e3-1f0f-17e1b05feae2@arm.com> <5ad6acdc69c1c2e1e17f5c701a09b7e1@codeaurora.org> <8affc09d4045812e2f5a065695b375de@codeaurora.org> Message-ID: <0ee3566e50143bac5b662b2edf551b89@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201021_032939_344685_BEFAFC52 X-CRM114-Status: GOOD ( 27.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peterz@infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, denik@google.com, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0xMC0yMCAyMTo0MCwgU2FpIFByYWthc2ggUmFuamFuIHdyb3RlOgo+IE9uIDIwMjAt MTAtMTQgMjE6MjksIFNhaSBQcmFrYXNoIFJhbmphbiB3cm90ZToKPj4gT24gMjAyMC0xMC0xNCAx ODo0NiwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPj4+IE9uIDEwLzE0LzIwMjAgMTA6MzYgQU0s IFNhaSBQcmFrYXNoIFJhbmphbiB3cm90ZToKPj4+PiBPbiAyMDIwLTEwLTEzIDIyOjA1LCBTdXp1 a2kgSyBQb3Vsb3NlIHdyb3RlOgo+Pj4+PiBPbiAxMC8wNy8yMDIwIDAyOjAwIFBNLCBTYWkgUHJh a2FzaCBSYW5qYW4gd3JvdGU6Cj4+Pj4+PiBUaGVyZSB3YXMgYSByZXBvcnQgb2YgTlVMTCBwb2lu dGVyIGRlcmVmZXJlbmNlIGluIEVURiBlbmFibGUKPj4+Pj4+IHBhdGggZm9yIHBlcmYgQ1MgbW9k ZSB3aXRoIFBJRCBtb25pdG9yaW5nLiBJdCBpcyBhbG1vc3QgMTAwJQo+Pj4+Pj4gcmVwcm9kdWNp YmxlIHdoZW4gdGhlIHByb2Nlc3MgdG8gbW9uaXRvciBpcyBzb21ldGhpbmcgdmVyeQo+Pj4+Pj4g YWN0aXZlIHN1Y2ggYXMgY2hyb21lIGFuZCB3aXRoIEVURiBhcyB0aGUgc2luayBhbmQgbm90IEVU Ui4KPj4+Pj4+IEN1cnJlbnRseSBpbiBhIGJpZCB0byBmaW5kIHRoZSBwaWQsIHRoZSBvd25lciBp cyBkZXJlZmVyZW5jZWQKPj4+Pj4+IHZpYSB0YXNrX3BpZF9ucigpIGNhbGwgaW4gdG1jX2VuYWJs ZV9ldGZfc2lua19wZXJmKCkgYW5kIHdpdGgKPj4+Pj4+IG93bmVyIGJlaW5nIE5VTEwsIHdlIGdl dCBhIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZS4KPj4+Pj4+IAo+Pj4+Pj4gTG9va2luZyBhdCB0 aGUgRVRSIGFuZCBvdGhlciBwbGFjZXMgaW4gdGhlIGtlcm5lbCwgRVRGIGFuZCB0aGUKPj4+Pj4+ IEVUQiBhcmUgdGhlIG9ubHkgcGxhY2VzIHRyeWluZyB0byBkZXJlZmVyZW5jZSB0aGUgdGFzayhv d25lcikKPj4+Pj4+IGluIHRtY19lbmFibGVfZXRmX3NpbmtfcGVyZigpIHdoaWNoIGlzIGFsc28g Y2FsbGVkIGZyb20gdGhlCj4+Pj4+PiBzY2hlZF9pbiBwYXRoIGFzIGluIHRoZSBjYWxsIHRyYWNl LiBPd25lcih0YXNrKSBpcyBOVUxMIGV2ZW4KPj4+Pj4+IGluIHRoZSBjYXNlIG9mIEVUUiBpbiB0 bWNfZW5hYmxlX2V0cl9zaW5rX3BlcmYoKSwgYnV0IHNpbmNlIHdlCj4+Pj4+PiBjYWNoZSB0aGUg UElEIGluIGFsbG9jX2J1ZmZlcigpIGNhbGxiYWNrIGFuZCBpdCBpcyBkb25lIGFzIHBhcnQKPj4+ Pj4+IG9mIGV0bV9zZXR1cF9hdXgoKSB3aGVuIGFsbG9jYXRpbmcgYnVmZmVyIGZvciBFVFIgc2lu aywgd2UgbmV2ZXIKPj4+Pj4+IGRlcmVmZXJlbmNlIHRoaXMgTlVMTCBwb2ludGVyIGFuZCB3ZSBh cmUgc2FmZS4gU28gbGV0cyBkbyB0aGUKPj4+Pj4gCj4+Pj4+IFRoZSBwYXRjaCBpcyBuZWNlc3Nh cnkgdG8gZml4IHNvbWUgb2YgdGhlIGlzc3Vlcy4gQnV0IEkgZmVlbCBpdCBpcwo+Pj4+PiBub3Qg Y29tcGxldGUuIFdoeSBpcyBpdCBzYWZlIGVhcmxpZXIgYW5kIG5vdCBsYXRlciA/IEkgYmVsaWV2 ZSB3ZSAKPj4+Pj4gYXJlCj4+Pj4+IHNpbXBseSByZWR1Y2luZyB0aGUgY2hhbmNlcyBvZiBoaXR0 aW5nIHRoZSBpc3N1ZSwgYnkgZG9pbmcgdGhpcyAKPj4+Pj4gZWFybGllciB0aGFuCj4+Pj4+IGxh dGVyLiBJIHdvdWxkIHNheSB3ZSBiZXR0ZXIgZml4IGFsbCBpbnN0YW5jZXMgdG8gbWFrZSBzdXJl IHRoYXQgCj4+Pj4+IHRoZQo+Pj4+PiBldmVudC0+b3duZXIgaXMgdmFsaWQuIChlLmcsIEkgY2Fu IHNlZSB0aGF0IHRoZSBmb3Iga2VybmVsIGV2ZW50cwo+Pj4+PiBldmVudC0+b3duZXIgPT0gLTEg PykKPj4+Pj4gCj4+Pj4+IHN0cnVjdCB0YXNrX3N0cnVjdCAqdHNrID0gUkVBRF9PTkNFKGV2ZW50 LT5vd25lcik7Cj4+Pj4+IAo+Pj4+PiBpZiAoIXRzayB8fCBpc19rZXJuZWxfZXZlbnQoZXZlbnQp KQo+Pj4+PiDCoMKgIC8qIHNraXAgPyAqLwo+Pj4+PiAKPj4+PiAKPj4+PiBMb29raW5nIGF0IGl0 IHNvbWUgbW9yZSwgaXNfa2VybmVsX2V2ZW50KCkgaXMgbm90IGV4cG9zZWQKPj4+PiBvdXRzaWRl IGV2ZW50cyBjb3JlIGFuZCBwcm9iYWJseSBmb3IgZ29vZCByZWFzb24uIFdoeSBkbwo+Pj4+IHdl IG5lZWQgdG8gY2hlY2sgZm9yIHRoaXMgYW5kIG5vdCBqdXN0IHRzaz8KPj4+IAo+Pj4gQmVjYXVz ZSB0aGUgZXZlbnQtPm93bmVyIGNvdWxkIGJlIDoKPj4+IAo+Pj4gID0gTlVMTAo+Pj4gID0gLTFV TCAgLy8ga2VybmVsIGV2ZW50Cj4+PiAgPSB2YWxpZC4KPj4+IAo+PiAKPj4gWWVzIEkgdW5kZXJz dG9vZCB0aGF0IHBhcnQsIGJ1dCBoZXJlIHdlIHdlcmUgdHJ5aW5nIHRvCj4+IGZpeCB0aGUgTlVM TCBwb2ludGVyIGRlcmVmZXJlbmNlIHJpZ2h0IGFuZCBoZW5jZSB0aGUKPj4gcXVlc3Rpb24gYXMg dG8gd2h5IHdlIG5lZWQgdG8gY2hlY2sgZm9yIGtlcm5lbCBldmVudHM/Cj4+IEkgYW0gbm8gZXhw ZXJ0IGluIHBlcmYgYnV0IEkgZG9uJ3Qgc2VlIGFueXdoZXJlIGluIHRoZQo+PiBrZXJuZWwgY2hl Y2tpbmcgZm9yIGlzX2tlcm5lbF9ldmVudCgpLCBzbyBJIGFtIGEgYml0Cj4+IHNrZXB0aWNhbCBp ZiBleHBvcnRpbmcgdGhhdCBpcyBhY3R1YWxseSByaWdodCBvciBub3QuCj4+IAo+IAo+IEkgaGF2 ZSBzdHJlc3MgdGVzdGVkIHdpdGggdGhlIG9yaWdpbmFsIHBhdGNoIG1hbnkgdGltZXMKPiBub3cs IGkuZS4sIHdpdGhvdXQgYSBjaGVjayBmb3IgZXZlbnQtPm93bmVyIGFuZCBpc19rZXJuZWxfZXZl bnQoKQo+IGFuZCBkaWRuJ3Qgb2JzZXJ2ZSBhbnkgY3Jhc2guIFBsdXMgb24gRVRSIHdoZXJlIHRo aXMgd2FzIGFscmVhZHkKPiBkb25lLCBubyBjcmFzaGVzIHdlcmUgcmVwb3J0ZWQgdGlsbCBkYXRl IGFuZCB3aXRoIEVURiwgdGhlIGlzc3VlCj4gd2FzIHF1aWNrbHkgcmVwcm9kdWNpYmxlLCBzbyBJ IGFtIGZhaXJseSBjb25maWRlbnQgdGhhdCB0aGlzCj4gZG9lc24ndCBqdXN0IGRlbGF5IHRoZSBv cmlnaW5hbCBpc3N1ZSBidXQgYWN0dWFsbHkgZml4ZXMKPiBpdC4gSSB3aWxsIHJ1biBhbiBvdmVy bmlnaHQgdGVzdCBhZ2FpbiB0byBjb25maXJtIHRoaXMuCj4gCgpJIHJhbiB0aGUgb3Zlcm5pZ2h0 IHRlc3Qgd2hpY2ggY29sbGVjdGVkIGFyb3VuZyA0RyBkYXRhKHNlZSBiZWxvdyksCndpdGggdGhl IGZvbGxvd2luZyBzbWFsbCBjaGFuZ2UgdG8gc2VlIGlmIHRoZSB0d28gY2FzZXMKKGV2ZW50LT5v d25lcj1OVUxMIGFuZCBpc19rZXJuZWxfZXZlbnQoKSkgYXJlIHRyaWdnZXJlZAp3aXRoIHN1Z2dl c3RlZCBjaGFuZ2VzIGFuZCBpdCBkaWRuJ3QgdHJpZ2dlciBhdCBhbGwuCkRvIHdlIHN0aWxsIG5l ZWQgdGhvc2UgYWRkaXRpb25hbCBjaGVja3M/CgpbIHBlcmYgcmVjb3JkOiBDYXB0dXJlZCBhbmQg d3JvdGUgNDY3Ny45ODkgTUIgcGVyZi5kYXRhIF0KCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3dHJh Y2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRtYy1ldGYuYyAKYi9kcml2ZXJzL2h3dHJhY2luZy9j b3Jlc2lnaHQvY29yZXNpZ2h0LXRtYy1ldGYuYwppbmRleCA5ODlkOTY1ZjNkOTAuLjEyM2M0NDZj ZTU4NSAxMDA2NDQKLS0tIGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC10 bWMtZXRmLmMKKysrIGIvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC10bWMt ZXRmLmMKQEAgLTEzLDYgKzEzLDEzIEBACiAgI2luY2x1ZGUgImNvcmVzaWdodC10bWMuaCIKICAj aW5jbHVkZSAiY29yZXNpZ2h0LWV0bS1wZXJmLmgiCgorI2RlZmluZSBUQVNLX1RPTUJTVE9ORSAo KHZvaWQgKiktMUwpCisKK3N0YXRpYyBib29sIGlzX2tlcm5lbF9ldmVudDIoc3RydWN0IHBlcmZf ZXZlbnQgKmV2ZW50KQoreworICAgICAgIHJldHVybiBSRUFEX09OQ0UoZXZlbnQtPm93bmVyKSA9 PSBUQVNLX1RPTUJTVE9ORTsKK30KKwogIHN0YXRpYyBpbnQgdG1jX3NldF9ldGZfYnVmZmVyKHN0 cnVjdCBjb3Jlc2lnaHRfZGV2aWNlICpjc2RldiwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0cnVjdCBwZXJmX291dHB1dF9oYW5kbGUgKmhhbmRsZSk7CgpAQCAtMzkyLDYgKzM5OSwx NSBAQCBzdGF0aWMgdm9pZCAqdG1jX2FsbG9jX2V0Zl9idWZmZXIoc3RydWN0IApjb3Jlc2lnaHRf ZGV2aWNlICpjc2RldiwKICB7CiAgICAgICAgIGludCBub2RlOwogICAgICAgICBzdHJ1Y3QgY3Nf YnVmZmVycyAqYnVmOworICAgICAgIHN0cnVjdCB0YXNrX3N0cnVjdCAqdGFzayA9IFJFQURfT05D RShldmVudC0+b3duZXIpOworCisgICAgICAgaWYgKCF0YXNrKSB7CisgICAgICAgICAgICAgICBw cl9pbmZvKCIqKnNhaSBpbiB0YXNrPU5VTEwqKlxuIik7CisgICAgICAgICAgICAgICByZXR1cm4g TlVMTDsKKyAgICAgICB9CisKKyAgICAgICBpZiAoaXNfa2VybmVsX2V2ZW50MihldmVudCkpCisg ICAgICAgICAgICAgICBwcl9pbmZvKCIqKnNhaSBpbiBpc19rZXJuZWxfZXZlbnQqKlxuIik7Cgog ICAgICAgICBub2RlID0gKGV2ZW50LT5jcHUgPT0gLTEpID8gTlVNQV9OT19OT0RFIDogCmNwdV90 b19ub2RlKGV2ZW50LT5jcHUpOwoKClRoYW5rcywKU2FpCgotLSAKUVVBTENPTU0gSU5ESUEsIG9u IGJlaGFsZiBvZiBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIAptZW1iZXIK b2YgQ29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlvbgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=