Re: [PATCH 3/5] eventpoll: add file based control interface

[Jens Axboe <axboe@kernel.dk>]

On 5/12/26 1:50 PM, Christian Brauner wrote:
> On Sun, 03 May 2026 02:49:14 -0600, Jens Axboe <axboe@kernel.dk> wrote:
>> diff --git a/include/linux/eventpoll.h b/include/linux/eventpoll.h
>> index 7bf30e9f90d7..4a6fe989810b 100644
>> --- a/include/linux/eventpoll.h
>> +++ b/include/linux/eventpoll.h
>> @@ -61,6 +61,13 @@ static inline void eventpoll_release(struct file *file)
>>  	eventpoll_release_file(file);
>>  }
>>  
>> +struct epoll_filefd {
>> +	struct file *file;
>> +	int fd;
>> +} __packed;
> 
> Since you're exposing this in a header now can we please rename this to:
> 
> struct epoll_key
> 
> This weird {file, fd} pairing is strange enough as it is.

I'm all for that, but let's do that as another cleanup on top. This way
we can keep this one purely mechanical.

-- 
Jens Axboe