From: "Chanwoo Choi" <cw00.choi@samsung.com>
To: "'Randy Dunlap'" <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: "'Andy Gross'" <agross@kernel.org>,
"'Bjorn Andersson'" <andersson@kernel.org>,
"'Konrad Dybcio'" <konrad.dybcio@linaro.org>,
"'MyungJoo Ham'" <myungjoo.ham@samsung.com>
Subject: RE: [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment
Date: Tue, 12 Dec 2023 09:34:39 +0900 [thread overview]
Message-ID: <0ef101da2c92$fe2ab4f0$fa801ed0$@samsung.com> (raw)
In-Reply-To: <20231205231204.1130-1-rdunlap@infradead.org>
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Wednesday, December 6, 2023 8:12 AM
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Andy Gross <agross@kernel.org>;
> Bjorn Andersson <andersson@kernel.org>; Konrad Dybcio
> <konrad.dybcio@linaro.org>; MyungJoo Ham <myungjoo.ham@samsung.com>;
Chanwoo
> Choi <cw00.choi@samsung.com>
> Subject: [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for
> comment
>
> Do not use "/**" for non-kernel-doc comments. This prevents a warning from
> scripts/kernel-doc:
>
> warning: expecting prototype for extcon(). Prototype was for
> USB_ID_DEBOUNCE_MS() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/extcon/extcon-qcom-spmi-misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-
> qcom-spmi-misc.c
> --- a/drivers/extcon/extcon-qcom-spmi-misc.c
> +++ b/drivers/extcon/extcon-qcom-spmi-misc.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
> * extcon-qcom-spmi-misc.c - Qualcomm USB extcon driver to support USB ID
> * and VBUS detection based on extcon-usb-gpio.c.
> *
Applied it. Thanks.
Best Regards,
Chanwoo Choi
prev parent reply other threads:[~2023-12-12 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231205231212epcas1p3e1fd5a1a34013c9a735947dea09ebbeb@epcas1p3.samsung.com>
2023-12-05 23:12 ` [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment Randy Dunlap
2023-12-12 0:34 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0ef101da2c92$fe2ab4f0$fa801ed0$@samsung.com' \
--to=cw00.choi@samsung.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.