From: "Gorski, Mateusz" <mateusz.gorski@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, tiwai@suse.com
Subject: Re: [PATCH v2] topology: Add topology file for generic HDA DSP machine driver
Date: Fri, 13 Mar 2020 08:08:16 +0100 [thread overview]
Message-ID: <0efdc802-eb82-2137-19a1-9a7e71fa62d8@linux.intel.com> (raw)
In-Reply-To: <27e153ce-f94b-876a-32e7-66dd5842c07b@linux.intel.com>
>>>> +SectionPCMCapabilities."DMIC-Capture" {
>>>> + formats "S16_LE"
>>>> + rates "48000"
>>>> + channels_min "2"
>>>> + channels_max "2"
>>>> + sig_bits "16"
>>>> +}
>>>
>>> NHLT reports 4 microphones on a number of devices, is there any
>>> specific reason to limit the capture to 2ch?
>>>
>>> I believe the generic Hdaudio card now reports the number of
>>> channels to pulseaudio, so it's possible that PulseAudio would open
>>> a 4ch stream but be told sorry no can do by topology.
>>>
>>> FWIW we ended-up selecting different topology files in SOF,
>>> depending on whether we had 0, 2 or 4 mics.
>>
>>
>> This patch was prepared to address many issues regarding broken DMIC
>> configurations.
>>
>> You are right - there are different DMIC configurations on different
>> devices, but, since path multi-configuration feature is not
>> upstreamed in cAVS driver, we are not able to include all of these in
>> one topology file.
>>
>> This is a reference topology, and it was successfully validated on
>> few production laptops (including models on which DMIC capture was
>> not working).
>
> Sorry, I don't understand what's missing in the cAVS driver?
>
> All you need is to select a different topology based on the number of
> DMICs detected.
We have a mechanism to choose the PCM configuration of given topology
path via amixer control. That way we can include both 2ch and 4ch DMIC
configurations in one topology file and simply change DMIC pipeline
configuration on runtime.
Unfortunately this mechanism is not currently available on upstream.
As said before, this is a reference topology, if needed I can also
upload modified version with 4ch DMIC path.
next prev parent reply other threads:[~2020-03-13 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 12:09 [PATCH v2] topology: Add topology file for generic HDA DSP machine driver Mateusz Gorski
2020-03-09 17:10 ` Pierre-Louis Bossart
2020-03-11 9:13 ` Gorski, Mateusz
2020-03-11 14:48 ` Pierre-Louis Bossart
2020-03-13 7:08 ` Gorski, Mateusz [this message]
2020-03-13 16:13 ` Pierre-Louis Bossart
2020-03-25 12:21 ` Gorski, Mateusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0efdc802-eb82-2137-19a1-9a7e71fa62d8@linux.intel.com \
--to=mateusz.gorski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.