Re: phosphor-bmc-code-memt: Support redfish remote firmware update with static layout image

[Adriana Kobylak <anoo@linux.ibm.com>]

>> phosphor-bmc-code-memt doesn’t support static-layout remote update 
>> since static layout fw package could only has “image-bmc” in the 
>> package.
> 
> For now, it does support static layout, you just need to upload the
> tarball contains separated images, instead of the whole "image-bmc"
> tarball.
> 

Checking the build files, the *.static.mtd.all.tar contains the 
image-bmc, manifest and signature files so yeah we can just upload that 
file without any build changes, we just need to add the support in the 
bmc-code-mgmt repo.

>> 
>> 
>> Following are the modifications
>> 
>> 1. Add a name list for static layout only has image-bmc in the fw 
>> package and modify related image file checking.
>> 
>> 2. Add checking ApplyTime property for static layout to decide whether 
>> reboot to apply update process or not.
>> 
>> 
>> 
>> Please find the patch for these modifications in the attachment.

Looks good, if you could just break the patch into two separate patches, 
one for the supporting image-bmc and one for adding the ApplyTime 
property, and submit via gerrit as Lei YU pointed. Let us know if you 
have any questions with the process. Thanks!

> 
> It may be useful to support the whole image as well, so please submit
> the code to gerrit, and we could review the code.
> Please follow
> https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#submitting-changes-via-gerrit-server-to-openbmc
> for how to submit changes to gerrit.
> Thanks!