From: Waiman Long <longman@redhat.com>
To: Frederic Weisbecker <frederic@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Roman Gushchin <roman.gushchin@linux.dev>,
Michal Hocko <mhocko@suse.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Leonardo <leobras@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] sched/isolation: Add cpu_is_isolated() API
Date: Fri, 3 Feb 2023 22:53:46 -0500 [thread overview]
Message-ID: <0f388863-9498-e61e-e2dc-965654544489@redhat.com> (raw)
In-Reply-To: <20230203232409.163847-3-frederic@kernel.org>
On 2/3/23 18:24, Frederic Weisbecker wrote:
> Provide this new API to check if a CPU has been isolated either through
> isolcpus= or nohz_full= kernel parameter.
>
> It aims at avoiding kernel load deemed to be safely spared on CPUs
> running sensitive workload that can't bear any disturbance, such as
> pcp cache draining.
>
> Suggested-by: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> include/linux/sched/isolation.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h
> index b645cc81fe01..088672f08469 100644
> --- a/include/linux/sched/isolation.h
> +++ b/include/linux/sched/isolation.h
> @@ -53,4 +53,10 @@ static inline bool housekeeping_cpu(int cpu, enum hk_type type)
> return true;
> }
>
> +static inline bool cpu_is_isolated(int cpu)
> +{
> + return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) ||
> + !housekeeping_test_cpu(cpu, HK_TYPE_KERNEL_NOISE);
> +}
> +
> #endif /* _LINUX_SCHED_ISOLATION_H */
CPUs in an isolated cpuset partition is similar to HK_TYPE_DOMAIN CPUs
as load balancing is disabled. I can add an API to access the cpumask
and add to this API. However, that list is dynamic as it can be changed
at run time. Will that be a problem? Or should that be used separately?
Cheers,
Longman
next prev parent reply other threads:[~2023-02-04 3:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 23:24 [PATCH 0/2] sched/isolation: Prep work for pcp cache draining isolation Frederic Weisbecker
2023-02-03 23:24 ` Frederic Weisbecker
[not found] ` <20230203232409.163847-1-frederic-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-02-03 23:24 ` [PATCH 1/2] sched/isolation: Merge individual nohz_full features into a common housekeeping flag Frederic Weisbecker
2023-02-03 23:24 ` Frederic Weisbecker
2023-02-06 15:51 ` Michal Koutný
[not found] ` <20230206155107.GA31453-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2023-02-07 11:49 ` Frederic Weisbecker
2023-02-07 11:49 ` Frederic Weisbecker
2023-02-07 12:59 ` Michal Koutný
2023-02-07 12:59 ` Michal Koutný
[not found] ` <20230207125900.GA24523-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2023-02-07 15:21 ` Waiman Long
2023-02-07 15:21 ` Waiman Long
2023-02-03 23:24 ` [PATCH 2/2] sched/isolation: Add cpu_is_isolated() API Frederic Weisbecker
2023-02-03 23:24 ` Frederic Weisbecker
2023-02-04 3:53 ` Waiman Long [this message]
[not found] ` <0f388863-9498-e61e-e2dc-965654544489-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2023-02-06 15:47 ` Michal Koutný
2023-02-06 15:47 ` Michal Koutný
[not found] ` <20230206154710.GC21332-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2023-02-06 16:50 ` Waiman Long
2023-02-06 16:50 ` Waiman Long
2023-02-07 12:16 ` Frederic Weisbecker
2023-02-07 12:16 ` Frederic Weisbecker
2023-02-05 5:47 ` kernel test robot
[not found] ` <20230203232409.163847-3-frederic-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-02-04 11:09 ` kernel test robot
2023-02-04 11:09 ` kernel test robot
2023-02-13 13:34 ` Michal Hocko
2023-02-13 13:34 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f388863-9498-e61e-e2dc-965654544489@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=frederic@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=leobras@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mtosatti@redhat.com \
--cc=muchun.song@linux.dev \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.