From: Damien Le Moal <dlemoal@kernel.org>
To: Yu Kuai <yukuai@kernel.org>,
jack@suse.cz, axboe@kernel.dk, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: Re: [PATCH v2] blk-ioc: don't hold queue_lock for ioc_lookup_icq()
Date: Mon, 28 Jul 2025 12:53:04 +0900 [thread overview]
Message-ID: <0f3f0978-eb42-4d83-81ad-e42cc482d674@kernel.org> (raw)
In-Reply-To: <20250725180334.40187-1-yukuai@kernel.org>
On 7/26/25 3:03 AM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Currently issue io can grab queue_lock three times from bfq_bio_merge(),
> bfq_limit_depth() and bfq_prepare_request(), the queue_lock is not
> necessary if icq is already created because both queue and ioc can't be
> freed before io issuing is done, hence remove the unnecessary queue_lock
> and use rcu to protect radix tree lookup.
>
> Noted this is also a prep patch to support request batch dispatching[1].
>
> [1] https://lore.kernel.org/all/20250722072431.610354-1-yukuai1@huaweicloud.com/
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Look OK.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-07-28 3:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 18:03 [PATCH v2] blk-ioc: don't hold queue_lock for ioc_lookup_icq() Yu Kuai
2025-07-28 3:53 ` Damien Le Moal [this message]
2025-07-28 9:28 ` Jan Kara
2025-07-28 17:08 ` Yu Kuai
2025-07-28 21:45 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f3f0978-eb42-4d83-81ad-e42cc482d674@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=johnny.chenyi@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.