From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vdpa-sim: depend on HAS_DMA
Date: Mon, 6 Apr 2020 22:12:56 +0800 [thread overview]
Message-ID: <0f4f2502-e810-e87a-2fba-dc887d2f4272@redhat.com> (raw)
In-Reply-To: <20200406095931-mutt-send-email-mst@kernel.org>
On 2020/4/6 下午10:02, Michael S. Tsirkin wrote:
> On Mon, Apr 06, 2020 at 06:09:27AM -0700, Christoph Hellwig wrote:
>> Pleae just drop the code - we should not add new drivers with custom
>> DMA ops.
> I'm not sure there's another way to do this: this not a driver, it's a
> software emulator that pretends to be an actual device. We can't
> have the platform supply DMA ops here since the platform is a regular
> x86 or whatever.
Yes, actually vdpa-sim does not depends on HAS_DMA. Maybe we can do
shortcut like dev->dma_ops = vdpasim_dma_ops;
Thanks
>
next prev parent reply other threads:[~2020-04-06 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 8:14 [PATCH] vdpa-sim: depend on HAS_DMA Michael S. Tsirkin
2020-04-05 8:14 ` Michael S. Tsirkin
2020-04-06 0:34 ` Jason Wang
2020-04-06 13:09 ` Christoph Hellwig
2020-04-06 14:02 ` Michael S. Tsirkin
2020-04-06 14:12 ` Jason Wang [this message]
2020-04-06 15:50 ` Michael S. Tsirkin
2020-04-10 9:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f4f2502-e810-e87a-2fba-dc887d2f4272@redhat.com \
--to=jasowang@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.