From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F777C4338F for ; Thu, 19 Aug 2021 16:01:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 806D56108B for ; Thu, 19 Aug 2021 16:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 806D56108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6428782C90; Thu, 19 Aug 2021 18:01:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="KKDD5AuE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E9F3082DD9; Thu, 19 Aug 2021 18:01:52 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20629.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::629]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7CAB78201E for ; Thu, 19 Aug 2021 18:01:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SjJjO3hFBZiBK93K7hsHrgjfbd9u0qhbDqZ447ZukKA+eIl55nlHVeDJmElXX6aR+kmQRtQntTPvhw+LBNQtQaelWljNoPHzwUBIvBpuHeAuzcCYCt9PsoBwXzqoIP0W9vUByzpR/oHQhmCyiz3kV5fY9Nm9nSc9xU8dNRPzdkTWavrL7HDuzPzOXTrNfz8P/siYoStGXCPZqmkDOloVoQCWOllxtVEEmcYouLmXk+bTo2Pp3pNrBR/+4gPtXff6COnOR6pyKHSGtoW3yomGuB9+J8H66kDsCNd3IRsQjMtyu8ZhQ/TpC0gCPDMWGZoRGj7dZLu4QhtkTSp/oYbszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=131u0thMIWj+XplBDXvbY0BCmn0T4C+fqLuY9S9N4JQ=; b=Nb92gNFnNkjHQf73fbLt72A0WxqAIeCxWIGQiiBmwGclPjLLWQAfr5X90VwNsj70BXlkkzLIdR6Vpse0mf2FN2VrjndgWHERWpjImy2ba+IffW3WfSfLySKtsAEBebmUhg+DZPNyDJPXe/6o4NQ/i0+fVtWacr6+gCzavsU9buytxjEEMXkmm4WK/bVR0QyS74A2S5rvjgrhqDwxPELWdpacXPUJAycOTUFOtznupoft4GbWbwJ0cCS6WEiWB33bBza7x17V9s3dpbpketoUVp9K0RE2kqbbBZLyPfjau00v+ALV2ANj4BKRaQoIWMAvAPDGoBooFhiHjn649cHn8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=chromium.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=131u0thMIWj+XplBDXvbY0BCmn0T4C+fqLuY9S9N4JQ=; b=KKDD5AuEOErok7uZikH9A2iVFvXDb6y5aHEeu3hod6Oo0K45q2GMfWcYFGntFVUU9P7DNqND0nlHCegI0lLueRBuJ2OofFQ2X1/KyHPgxThor5IcDKnsiIeIAOo9jYwqaD7e+Ufixug0wR5FpA9Q1qchuAYtsUAycl+uL39kpm0= Received: from SN7PR04CA0093.namprd04.prod.outlook.com (2603:10b6:806:122::8) by BY5PR02MB6469.namprd02.prod.outlook.com (2603:10b6:a03:1c4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Thu, 19 Aug 2021 16:01:45 +0000 Received: from SN1NAM02FT0033.eop-nam02.prod.protection.outlook.com (2603:10b6:806:122:cafe::ce) by SN7PR04CA0093.outlook.office365.com (2603:10b6:806:122::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Thu, 19 Aug 2021 16:01:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0033.mail.protection.outlook.com (10.97.5.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4436.19 via Frontend Transport; Thu, 19 Aug 2021 16:01:44 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 19 Aug 2021 09:01:43 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 19 Aug 2021 09:01:43 -0700 Envelope-to: git@xilinx.com, sjg@chromium.org, pali@kernel.org, marek.behun@nic.cz, chee.hong.ang@intel.com, bmeng.cn@gmail.com, u-boot@lists.denx.de, andre.przywara@arm.com Received: from [172.30.17.109] (port=40178) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mGkU9-0008rc-UW; Thu, 19 Aug 2021 09:01:42 -0700 Subject: Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems To: Andre Przywara , Michal Simek , , CC: Bin Meng , Chee Hong Ang , =?UTF-8?Q?Marek_Beh=c3=ban?= , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Simon Glass References: <835b6be6-6f63-913c-7872-f043c82f8fe5@arm.com> From: Michal Simek Message-ID: <0f5c68ec-4396-1088-a650-b284d9007190@xilinx.com> Date: Thu, 19 Aug 2021 18:01:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <835b6be6-6f63-913c-7872-f043c82f8fe5@arm.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 447bffeb-24e0-4197-13df-08d9632aa485 X-MS-TrafficTypeDiagnostic: BY5PR02MB6469: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x5b8B75oVRJuaHSzJJ1Kqa0BRGIYCUpd9rClFLoF8fQWrKXh7EIxwsKq8wplw4ErHAOd8mMR1H6QTPUFg/Gh6/DPjC5N7wX2jMi1lBGqSzuh4mD88ailwzOzez2lxVnaG9c8Awfyv6akEW0f3noqTDuSzXq1Uv244BtPyV6FNzLiiD0QDrt82b9Qo847x//Ohz4rfT2nypbnsF0qWN1khbbOlPpiWsiz/6j19vy+yfwxOhlLYVmfzWF/Q+eZ3EoQXzYH9EACigzLch9d1tpNfupJWC2MHy8BAyvMlChj6PfpGRW+6ACgK7xAy44n1iJAFOUszIdOdAYokuhCJTFP7UWgkt5SrzjBSdOmNSEN4P+zsrL+HBPhOBNp4U725eSAczSLCVt2UKvj/d7PiMd1jGBKHk3N8nXsTfxRZIxgYjgtxBjXcjLpDg10Y5jMhzewIaylff9A9Dep+L50wSwhnM9n93QtpTrE5tL+lLQ8pV1oxNGrNN0xU6dnlOVMIW7T2qWlNQkN85BaUMgse0d9CokZ7fJ4J488+D4KNnzeuNb1BH3l8EgeoHTiMtW+XxkWa8i6+HOh8wDvvYZ1AdANyFCzjUlsRkvyrWWTkUF/1/tBRAY5O3ZntJq7k1+1+mdO5cNEf8Kbrxjx4QrO/0MvO5Y8ye9Vrzy30WJVXXHgAku35xZfkr8kgYb4ObyWIKlOk1CdvN2FJnb/ZguypXqMNwj7I9cCK3mXTDqVULQAoMksmWPItn6tyf4z6BnVg4xF2vc9V1T3c+PPHggsP36c4Q== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966006)(36840700001)(2616005)(54906003)(110136005)(478600001)(31696002)(36906005)(31686004)(44832011)(316002)(6636002)(36860700001)(47076005)(8936002)(7636003)(70206006)(82740400003)(6666004)(36756003)(356005)(2906002)(9786002)(5660300002)(83380400001)(4326008)(186003)(8676002)(26005)(53546011)(426003)(82310400003)(336012)(70586007)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2021 16:01:44.8787 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 447bffeb-24e0-4197-13df-08d9632aa485 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0033.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6469 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Andre, On 8/19/21 5:56 PM, Andre Przywara wrote: > On 8/19/21 12:19 PM, Michal Simek wrote: > > Hi, > >> Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT >> image placed and aligned only by 32bits (4bytes). For 64bit systems there >> is 64bit (8bytes) alignment required. That's why make sure that >> fit-dtb.blob and u-boot.itb as our primary target images for Xilinx >> ZynqMP >> are all 64bit aligned. The patch is using CONFIG_PHYS_64BIT macro to >> identify 64bit systems (including 32bit systems with PAE). >> >> Signed-off-by: Michal Simek >> --- >> >>   Makefile | 7 +++++++ >>   1 file changed, 7 insertions(+) >> >> diff --git a/Makefile b/Makefile >> index 269e353a28ad..1bbe95595efe 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1169,6 +1169,10 @@ MKIMAGEFLAGS_fit-dtb.blob = -f auto -A $(ARCH) >> -T firmware -C none -O u-boot \ >>       -a 0 -e 0 -E \ >>       $(patsubst %,-b arch/$(ARCH)/dts/%.dtb,$(subst >> ",,$(CONFIG_OF_LIST))) -d /dev/null >>   +ifeq ($(CONFIG_PHYS_64BIT),y) > > Why is this restricted to 64-bit "systems"? The DT spec[1] clearly > states that some DT parts (/memreserved/ block, for instance), must be > 64-bit aligned, which means the whole blobs needs to be 64-bit aligned. > Granted this probably does not cause real issues on 32-bit systems, but > is violating the spec anyway. > So I'd say we add the alignment requirement unconditionally. That's even better for me and we need to make sure that dtbs itself are aligned and also dtbs inside FIT image are aligned too. Cheers, Michal