From: "Frank Filz" <ffilzlnx@mindspring.com>
To: "'Bruce Fields'" <bfields@redhat.com>, <trondmy@kernel.org>
Cc: "'Chuck Lever'" <chuck.lever@oracle.com>,
"'Linux NFS Mailing List'" <linux-nfs@vger.kernel.org>
Subject: pynfs V3 ideas - WAS: [PATCH 5/9] nfsd: NFSv3 should allow zero length writes
Date: Mon, 20 Dec 2021 09:42:07 -0800 [thread overview]
Message-ID: <0f7201d7f5c8$e913c410$bb3b4c30$@mindspring.com> (raw)
> On Fri, Dec 17, 2021 at 5:07 PM <trondmy@kernel.org> wrote:
> >
> > From: Trond Myklebust <trond.myklebust@hammerspace.com>
> >
> > According to RFC1813: "If count is 0, the WRITE will succeed and
> > return a count of 0, barring errors due to permissions checking."
>
> Yes, I'm surprised we're not already doing this right.
>
> I wonder how far back this bug goes.
>
> The svc.c code is from 8154ef2776aa "NFSD: Clean up legacy NFS WRITE
> argument XDR decoders", but the behavior might predate that code. The
> nfsd_vfs_write() logic, I'm not sure I understand.
>
> We have a pynfs test for the v4 case (WRT4), but I guess we must have nothing
> testing the v3 case.
Hmm, need to try and remember this... I am slowly working on pnfs V3 test cases so I will try and make sure edge cases like this get tested.
Frank
reply other threads:[~2021-12-20 17:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0f7201d7f5c8$e913c410$bb3b4c30$@mindspring.com' \
--to=ffilzlnx@mindspring.com \
--cc=bfields@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.