Re: [peterz-queue:perf/core 26/39] arch/x86/include/asm/perf_event.h:290:19: error: flexible array member in a struct with no named members

[Liang, Kan <kan.liang@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]


>>> arch/x86/include/asm/perf_event.h:290:19: error: flexible array member in a struct with no named members
>       290 |  struct lbr_entry lbr[]; /* Variable length */
>           |                   ^~~
>     kernel/sched/rt.c:253:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes]
>       253 | void free_rt_sched_group(struct task_group *tg) { }
>           |      ^~~~~~~~~~~~~~~~~~~
>     kernel/sched/rt.c:255:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes]
>       255 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
>           |     ^~~~~~~~~~~~~~~~~~~~
>     kernel/sched/rt.c:668:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
>       668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
>           |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> vim +290 arch/x86/include/asm/perf_event.h
> 
>     288	
>     289	struct pebs_lbr {
>   > 290		struct lbr_entry lbr[]; /* Variable length */
>     291	};
>     292	
>

The struct pebs_lbr only has one member. To fix the warning, it seems we 
have to define the struct as below.


diff --git a/arch/x86/include/asm/perf_event.h 
b/arch/x86/include/asm/perf_event.h
index 2338200..a387e14 100644
--- a/arch/x86/include/asm/perf_event.h
+++ b/arch/x86/include/asm/perf_event.h
@@ -283,7 +283,7 @@ struct pebs_xmm {
  };

  struct pebs_lbr {
-	struct lbr_entry lbr[]; /* Variable length */
+	struct lbr_entry lbr[0]; /* Variable length */
  };


Thanks,
Kan