Re: [PATCH 0/2] Add MIPI CSI-2 receiver support for RK3576

[Michael Riesch <michael.riesch@collabora.com>]

Hi Amin,

On 8/26/26 14:33, Amin Gattout wrote:
> This series adds the device tree binding and the SoC nodes for the
> MIPI CSI-2 receiver units of the Rockchip RK3576. The receiver is the
> same Synopsys DesignWare IP as in the RK3568 and the register map is
> identical, so the existing driver is used unchanged via a fallback
> compatible.
> 
> Only the two receivers fed by the Innosilicon D-PHYs in full mode
> (MIPI1 and MIPI3) are added; see patch 2 for the details.
> 
> This series depends on the RK3576 CSI D-PHY series [1], which provides
> the csi_dphy0/csi_dphy1 nodes referenced here.
> 
> [1] https://lore.kernel.org/r/20260820-rk3576-dphy-v1-0-70e25e8d5e78@gmail.com

Thanks for your work, LGTM!

Just one thing: It would be great if you could describe your test setup
a bit (HW components, test case, ...).

> 
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>

For this series:

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Best regards,
Michael

> ---
> Amin Gattout (2):
>       media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3576 compatible
>       arm64: dts: rockchip: add mipi csi-2 receiver nodes to rk3576
> 
>  .../bindings/media/rockchip,rk3568-mipi-csi2.yaml  |  1 +
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi           | 52 ++++++++++++++++++++++
>  2 files changed, 53 insertions(+)
> ---
> base-commit: bd5f485f3f026225b86573e559af0b7254ef4184
> change-id: 20260825-csi-2-rcv-dts-7712bd834de6
> prerequisite-change-id: 20260819-rk3576-dphy-2304f848215b:v1
> prerequisite-patch-id: fbe2d84f88709b8bf846debe6b8ce62c4392ca63
> prerequisite-patch-id: 9bce33933ae69e8cc7f7ef2f0d9acb969620bc85
> prerequisite-patch-id: aca697161c21e19fe3a7f62f208da0f6c3b666e1
> prerequisite-patch-id: 8f45701f840680a35e044f43ebd3087282847990
> 
> Best regards,
> --  
> Amin Gattout <amin.gattout@gmail.com>
>