From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Guenter Roeck <groeck@google.com>
Cc: Prashant Malani <pmalani@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
chrome-platform@lists.linux.dev,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Check for EC driver
Date: Fri, 8 Apr 2022 02:03:52 +0900 [thread overview]
Message-ID: <0fdba110-8743-3b2d-cb30-3a89b7cfa592@gmail.com> (raw)
In-Reply-To: <CABXOdTet5ynSXf94qMimobJF4LLzHc89cVbwJ5NuAz8G6jmVdQ@mail.gmail.com>
On 2022/04/08 1:28, Guenter Roeck wrote:
> On Wed, Apr 6, 2022 at 6:16 PM Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
> [ ... ]
>>>>> ec_dev = dev_get_drvdata(&typec->ec->ec->dev);
>
> I completely missed the part that this is not on the parent.
>
>>>>> + if (!ec_dev)
>>>>> + return -EPROBE_DEFER;
> [ ... ]
>>
>> 1. The parent exists and dev_get_drvdata(pdev->dev.parent) returns
>> non-NULL value. However, dev_get_drvdata(&typec->ec->ec->dev) returns
>> NULL. (Yes, that is confusing.) I'm wondering
>
> I am actually surprised that typec->ec->ec is not NULL. Underlying
> problem (or, one underlying problem) is that it is set in
> cros_ec_register():
>
> /* Register a platform device for the main EC instance */
> ec_dev->ec = platform_device_register_data(ec_dev->dev, "cros-ec-dev",
> PLATFORM_DEVID_AUTO, &ec_p,
> sizeof(struct cros_ec_platform));
>
> "cros-ec-dev" is the mfd device which instantiates the character
> device. On devicetree (arm64) systems, the typec device is registered
> as child of google,cros-ec-spi and thus should be instantiated only
> after the spi device has been instantiated. The same should happen on
> ACPI systems, but I don't know if that is really correct.
>
> I don't know what exactly is happening, but apparently typec
> registration happens in parallel with cros-ec-dev registration, which
> is delayed because the character device is not loaded. As mentioned, I
> don't understand why typec->ec->ec is not NULL. Can you check what it
> points to ?
If I read the code correctly, the registration itself happens
synchronously and platform_device_register_data() always returns a
non-NULL value unless it returns -ENOMEM. The driver, however, can be
asynchronously bound and dev_get_drvdata(&typec->ec->ec->dev) can return
NULL as the consequence. It would have a call trace like the following
when scheduling asynchronous driver binding:
platform_device_register_data()
platform_device_register_resndata()
platform_device_register_full()
- This always creates and returns platform_device.
platform_device_add()
- This adds the created platform_device.
device_add()
bus_probe_device()
device_initial_probe()
__device_attach()
- This schedules asynchronous probing.
typec->ec->ec should be pointing to the correct platform_device as the
patched driver works without Oops on my computer. It is not NULL at least.
Regards,
Akihiko Odaki
>
> Thanks,
> Guenter
>
>> dev_get_drvdata(pdev->dev.parent) returned NULL in the following crash
>> log but it would be a problem distinct from what is handled with my patch:
>> https://lore.kernel.org/lkml/CABXOdTe9u_DW=NZM1-J120Gu1gibDy8SsgHP3bJwwLsE_iuLAQ@mail.gmail.com/
>>
>> 2. My patch returns -EPROBE_DEFER instead of -ENODEV and I confirmed it
>> will eventually be instantiated.
>>
>> Regards,
>> Akihiko Odaki
>>
>>>
>>> Guenter
>>>
>>>> Thanks,
>>>>
>>>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/chrome?id=ffebd90532728086007038986900426544e3df4e
>>
next prev parent reply other threads:[~2022-04-07 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 4:11 [PATCH] platform/chrome: cros_ec_typec: Check for EC driver Akihiko Odaki
2022-04-04 4:11 ` Akihiko Odaki
2022-04-05 1:57 ` Guenter Roeck
2022-04-05 5:43 ` Akihiko Odaki
2022-04-06 21:16 ` Prashant Malani
2022-04-06 21:32 ` Guenter Roeck
2022-04-07 1:16 ` Akihiko Odaki
2022-04-07 16:28 ` Guenter Roeck
2022-04-07 17:03 ` Akihiko Odaki [this message]
2022-04-07 17:09 ` Benson Leung
2022-04-07 17:23 ` Akihiko Odaki
2022-04-07 18:51 ` Guenter Roeck
2022-04-20 10:50 ` patchwork-bot+chrome-platform
2022-05-10 23:00 ` patchwork-bot+chrome-platform
2022-05-12 17:20 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fdba110-8743-3b2d-cb30-3a89b7cfa592@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.