From: David Bremner <bremner@unb.ca>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Kristian Høgsberg" <krh@redhat.com>,
git@vger.kernel.org
Subject: Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin
Date: Tue, 04 Mar 2008 23:15:32 +0100 [thread overview]
Message-ID: <0tr6eq87az.wl%bremner@pivot.cs.unb.ca> (raw)
In-Reply-To: <alpine.LSU.1.00.0803041203320.22527@racer.site>
>>>>> "Johannes" == Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> Tue, 4 Mar 2008, David Bremner wrote:
>>
>> Yeah, I should have been more explicit. The problem is a line
>>
>> read -N1 VAR
Johannes> Can you be even more explicit? IOW why does this have
Johannes> to be a pre-commit hook, and cannot be done before
Johannes> calling git-commit itself?
I have this feeling I don't really understand the question. Yes, in
principle, whatever I am doing in a pre-commit hook could be done by
hand first. I guess it is primarily a user interface issue. The goal
is modify the behaviour of git-commit in a particular repository;
isn't this the purpose of pre-commit hooks?
All the best,
David
next prev parent reply other threads:[~2008-03-04 22:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 8:38 Bug#469250: Commit f5bbc322 to git broke pre-commit hooks which read stdin David Bremner
2008-03-04 10:45 ` Johannes Schindelin
2008-03-04 11:12 ` Junio C Hamano
2008-03-04 11:48 ` Johannes Sixt
2008-03-04 12:17 ` Junio C Hamano
2008-03-04 11:48 ` David Bremner
2008-03-04 12:04 ` Johannes Schindelin
2008-03-04 18:16 ` Joey Hess
2008-03-04 22:15 ` David Bremner [this message]
2008-03-05 5:12 ` Shawn O. Pearce
2008-03-05 5:36 ` Junio C Hamano
2008-03-05 5:46 ` Shawn O. Pearce
2008-03-04 11:51 ` Jakub Narebski
2008-03-04 12:03 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0tr6eq87az.wl%bremner@pivot.cs.unb.ca \
--to=bremner@unb.ca \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.