From: Steve Grubb <sgrubb@redhat.com>
To: Tyler Hicks <tyhicks@canonical.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH 1/3] Don't ignore the return value of asprintf()
Date: Sat, 09 Feb 2013 11:50:49 -0500 [thread overview]
Message-ID: <10014568.HifH6x9ZRN@x2> (raw)
In-Reply-To: <1360379555-1910-2-git-send-email-tyhicks@canonical.com>
On Friday, February 08, 2013 07:12:33 PM Tyler Hicks wrote:
> If an error occurs in asprintf(), the contents of the strp variable are
> undefined. asprintf()'s return value must be checked and the parameter
> passed into asprintf() should be set to NULL upon error.
Applied. I think there are a couple places where it will obviously segfault in
auditctl.c. But the patch does clean up a bunch of warnings.
-Steve
next prev parent reply other threads:[~2013-02-09 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 3:12 [PATCH 0/3] Fix userspace audit compiler warnings Tyler Hicks
2013-02-09 3:12 ` [PATCH 1/3] Don't ignore the return value of asprintf() Tyler Hicks
2013-02-09 16:50 ` Steve Grubb [this message]
2013-02-09 3:12 ` [PATCH 2/3] Fix Wunused-return warnings Tyler Hicks
2013-02-09 16:57 ` Steve Grubb
2013-02-09 18:35 ` Tyler Hicks
2013-02-09 3:12 ` [PATCH 3/3] Fix discards 'const' qualifier from pointer target type warnings Tyler Hicks
2013-02-09 17:22 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10014568.HifH6x9ZRN@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.