All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Barker <mikeb01@gmail.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [PATCH v2] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.
Date: Thu, 20 Jan 2022 15:16:47 +0100	[thread overview]
Message-ID: <10018405.DAOxP5AVGn@thomas> (raw)
In-Reply-To: <20220117232318.219749-1-mikeb01@gmail.com>

18/01/2022 00:23, Michael Barker:
> When using clang with -Wall the use of diagnose_if kicks up a warning,

Please could you copy the warning in the commit log?

> requiring all dpdk includes to be wrapped with the pragma.  This change
> isolates the ignore just the appropriate location and makes it easier
> for users to apply -Wall,-Werror

Please could you explain how it is related to -Wgcc-compat?

[...]
>  #define __rte_internal \
> +_Pragma("GCC diagnostic push") \
> +_Pragma("GCC diagnostic ignored \"-Wgcc-compat\"") \
>  __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \
> -section(".text.internal")))
> +section(".text.internal"))) \
> +_Pragma("GCC diagnostic pop")




  reply	other threads:[~2022-01-20 14:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 23:14 [PATCH] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if Michael Barker
2022-01-17 23:23 ` [PATCH v2] " Michael Barker
2022-01-20 14:16   ` Thomas Monjalon [this message]
2022-01-23 21:17     ` Michael Barker
2022-01-23 23:53       ` Stephen Hemminger
2022-01-23 21:07   ` [PATCH v3] " Michael Barker
2022-01-23 21:20     ` [PATCH v4] " Michael Barker
2022-01-23 23:55       ` Stephen Hemminger
2022-01-31  0:08         ` Michael Barker
2022-01-25 10:33       ` Ray Kinsella
2022-01-31  0:10         ` Michael Barker
2022-01-31  0:05       ` [PATCH v5] " Michael Barker
2022-02-12 14:00         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10018405.DAOxP5AVGn@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    --cc=mikeb01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.