From: Robert Love <rml@tech9.net>
To: Mike Fedyk <mfedyk@matchmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Compile Filure on 2.4.10-ac10+preempt+smp
Date: 10 Oct 2001 01:15:25 -0400 [thread overview]
Message-ID: <1002690949.862.233.camel@phantasy> (raw)
In-Reply-To: <20011009214655.A26663@mikef-linux.matchmail.com>
In-Reply-To: <20011009214655.A26663@mikef-linux.matchmail.com>
On Wed, 2001-10-10 at 00:46, Mike Fedyk wrote:
> Fail 2.4.10-ac10+preempt+smp
> Success 2.4.10-ac10+preempt+up-apic+up-ipapic
> Success 2.4.10-ac10+preempt
> Success 2.4.10-ac10
>
> Robert, can you do a test compile for smp just in case?
Ahh, yes. Thank you for spotting this. include/asm-i386/spinlock.h has
two separate defines for spin_unlock and we only renamed one of them. I
guess you hit the conditional that used the other define...
The attached patch fixes it.
> Also, I couldn't find any links to old patches on your web site...
> [...]
I only keep around patches to the last official kernel, plus the latest
-pre and -ac I patched. Since the patch itself is being updated, its a
pain to backport to older kernels.
--- linux-2.4.10-ac10/include/asm-i386/spinlock.h.orig Mon Oct 8 18:33:10 2001
+++ linux-2.4.10-ac10/include/asm-i386/spinlock.h Wed Oct 10 01:08:47 2001
@@ -97,7 +97,7 @@
:"=q" (oldval), "=m" (lock->lock) \
:"0" (1) : "memory"
-static inline void spin_unlock(spinlock_t *lock)
+static inline void _raw_spin_unlock(spinlock_t *lock)
{
char oldval;
#if SPINLOCK_DEBUG
Robert Love
next prev parent reply other threads:[~2001-10-10 5:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-10 4:46 Compile Filure on 2.4.10-ac10+preempt+smp Mike Fedyk
2001-10-10 5:15 ` Robert Love [this message]
2001-10-10 5:24 ` Mike Fedyk
2001-10-10 5:34 ` Robert Love
2001-10-10 6:00 ` Mike Fedyk
2001-10-10 22:52 ` Mike Fedyk
2001-10-10 23:06 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1002690949.862.233.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mfedyk@matchmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.