Re: [PATCH] 2.4.10-ac11 parport_pc.c bugfix

[Thomas Hood <jdthood@mail.com>]

I guess the question is: Which way is more portable?  Is
"(unsigned long)-1" liable to turn out as something other than
~0U?

If your way of expressing it is more portable then we should
make the change ... BOTH in pnp_bios.c and in parport_pc.c .

Opinions?

--
Thomas


On Thu, 2001-10-11 at 09:40, J . A . Magallon wrote:
> 
> On 20011011 Thomas Hood wrote:
> > 	} else {
> >-		if ( dev->irq_resource[0].start == -1 ) {
> >+		if ( dev->irq_resource[0].start == (unsigned long)-1 ) {
>                                                    ^^^^^^^^^      ^
> Uh ?
> 
> Perhaps I miss some black magic in kernel programming, but could not this
> be written much cleaner like
> 
> >+		if ( dev->irq_resource[0].start == ~0U ) {
> 
> -- 
> J.A. Magallon                           #  Let the source be with you...        
> mailto:jamagallon@able.es
> Mandrake Linux release 8.2 (Cooker) for i586
> Linux werewolf 2.4.10-ac11-beo #2 SMP Thu Oct 11 02:41:04 CEST 2001 i686
>