From: Thomas Hood <jdthood@mail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: kapm-idled Funny in 2.4.10-ac12
Date: 12 Oct 2001 15:40:24 -0400 [thread overview]
Message-ID: <1002915626.10291.67.camel@thanatos> (raw)
Just taking a walk through apm.c ...
I notice that set_time() calls get_cmos_time() with interrupts
disabled, whereas get_time_diff calls it with interrupts
enabled.
get_cmos_time is in time.c . It does a bunch of CMOS_READs
without taking rtc_lock.
Methinks that the
save_flags(flags); ...; cli(); ...; restore_flags(flags);
constructs in apm.c need some attention.
Thomas
next reply other threads:[~2001-10-12 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-12 19:40 Thomas Hood [this message]
2001-10-12 20:12 ` kapm-idled Funny in 2.4.10-ac12 Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2001-10-12 18:52 Thomas Hood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1002915626.10291.67.camel@thanatos \
--to=jdthood@mail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.