From: Robert Love <rml@tech9.net>
To: Andreas Dilger <adilger@turbolabs.com>
Cc: Rich Baum <richbaum@acm.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix compile warnings in 2.4.15pre9
Date: 22 Nov 2001 19:03:03 -0500 [thread overview]
Message-ID: <1006473785.1336.6.camel@icbm> (raw)
In-Reply-To: <20011122165454.P1308@lynx.no>
In-Reply-To: <132A4694022@coral.indstate.edu> <20011122165454.P1308@lynx.no>
On Thu, 2001-11-22 at 18:54, Andreas Dilger wrote:
> How about something like (not real patches, but you get the idea:
>
> @@ -4691,6 +4691,7 @@
> OUTL_DSP (SCRIPTA_BA (np, clrack));
> +out_stuck:
> return;
> -out_stuck:
> }
>
> @@ -5226,6 +5227,7 @@
>
> +fail:
> return;
> -fail:
> }
Yes, much better. Besides looking better, gcc _may_ generate different
code (I don't know how smart it is in this case) that has these "fall
throughs" and that would mean (a) less code and (b) less jumps -- always
a win.
Robert Love
prev parent reply other threads:[~2001-11-23 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-22 22:45 [PATCH] fix compile warnings in 2.4.15pre9 Rich Baum
2001-11-22 23:54 ` Andreas Dilger
2001-11-23 0:03 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1006473785.1336.6.camel@icbm \
--to=rml@tech9.net \
--cc=adilger@turbolabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richbaum@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.