From: Robert Love <rml@tech9.net>
To: marcelo@conectiva.com.br, andre@linux-ide.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] simple ide without proc compile fix
Date: 05 Dec 2001 18:20:49 -0500 [thread overview]
Message-ID: <1007594451.28567.18.camel@phantasy> (raw)
Attached patch is a repost now against 2.4.17-pre4.
IDE will not compile without CONFIG_PROC_FS defined. This patch fixes
that.
Yes, ifdefs in the code are not preferred. But this is merely following
the pattern in the rest of the ide*.c files (see other uses of
ide_remove_proc_entries -- just these two seem to be without ifdefs).
Please, apply.
Robert Love
--- linux-2.4.17-pre4/drivers/ide/ide-disk.c Wed Dec 5 15:16:57 2001
+++ linux/drivers/ide/ide-disk.c Wed Dec 5 18:13:35 2001
@@ -858,8 +858,10 @@
}
/* We must remove proc entries defined in this module.
Otherwise we oops while accessing these entries */
+#ifdef CONFIG_PROC_FS
if (drive->proc)
ide_remove_proc_entries(drive->proc, idedisk_proc);
+#endif
}
ide_unregister_module(&idedisk_module);
}
--- linux-2.4.17-pre4/drivers/ide/ide-floppy.c Wed Dec 5 15:16:57 2001
+++ linux/drivers/ide/ide-floppy.c Wed Dec 5 18:13:35 2001
@@ -2071,8 +2071,10 @@
}
/* We must remove proc entries defined in this module.
Otherwise we oops while accessing these entries */
+#ifdef CONFIG_PROC_FS
if (drive->proc)
ide_remove_proc_entries(drive->proc, idefloppy_proc);
+#endif
}
ide_unregister_module(&idefloppy_module);
}
next reply other threads:[~2001-12-05 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-05 23:20 Robert Love [this message]
2001-12-06 4:48 ` [PATCH] simple ide without proc compile fix David Weinehall
2001-12-06 5:08 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1007594451.28567.18.camel@phantasy \
--to=rml@tech9.net \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.