From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mail.openembedded.org (Postfix) with ESMTP id 6287377E26 for ; Mon, 22 May 2017 23:08:46 +0000 (UTC) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 22 May 2017 16:08:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,379,1491289200"; d="scan'208,217";a="104137685" Received: from olopezca-mobl2.amr.corp.intel.com (HELO [10.252.250.88]) ([10.252.250.88]) by orsmga005.jf.intel.com with ESMTP; 22 May 2017 16:08:46 -0700 To: Khem Raj , openembedded-core@lists.openembedded.org References: <20170522222523.15978-1-alejandro.hernandez@linux.intel.com> From: Alejandro Hernandez Message-ID: <10077e31-2f0d-2915-fa2c-38c5eadc8b87@linux.intel.com> Date: Mon, 22 May 2017 18:08:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] intltool: Adds gettext as a DEPENDS X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 23:08:48 -0000 Content-Type: multipart/alternative; boundary="------------AA8BC8FE1DF3D58CA163C897" Content-Language: en-US --------------AA8BC8FE1DF3D58CA163C897 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hey Khem, On 05/22/2017 05:41 PM, Khem Raj wrote: > > On Mon, May 22, 2017 at 3:25 PM Alejandro Hernandez > > wrote: > > When setting USE_NLS="no" and building systemd-boot > (which DEPENDS on intltool), configure fails, > complaining about missing gettext: > > configure: error: GNU gettext tools not found; required for intltool > > This is caused because USE_NLS="no" makes the gettext class > add gettext-minimal-native to BASEDEPENDS instead of adding > gettext-native. > > Since we still would like to set USE_NLS="no" and build systemd-boot, > we add gettext-native as a dependency to intltool-native, which > makes it > available for the configure script of systemd-boot fixing the problem. > > [YOCTO #11562] > > Signed-off-by: Alejandro Hernandez > > > --- > meta/recipes-devtools/intltool/intltool_0.51.0.bb > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb > > b/meta/recipes-devtools/intltool/intltool_0.51.0.bb > > index 551bdf0619a..ecff2faf253 100644 > --- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb > > +++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb > > @@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = > "https://launchpad.net/intltool/trunk/" > > DEPENDS = "libxml-parser-perl-native" > RDEPENDS_${PN} = "gettext-dev libxml-parser-perl" > -DEPENDS_class-native = "libxml-parser-perl-native" > +DEPENDS_class-native = "libxml-parser-perl-native gettext-native" > > > This will serialise the build I think it better to add the dep only > when NLS is down disabled I thought about doing so but I couldn't think of a clean way of doing it. I can't get rid of it on the gettext.bbclass since it would mess up the work on b090fde5c184 What I can do, is set gettext-native as a DEPENDS to systemd-boot which is the one that is actually complaining, this way we would keep returning gettext-minimal-native when USE_NLS="no", but we would also fix the issue, what do you think? > > > inherit autotools pkgconfig perlnative > > -- > 2.12.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > --------------AA8BC8FE1DF3D58CA163C897 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hey Khem,


On 05/22/2017 05:41 PM, Khem Raj wrote:

On Mon, May 22, 2017 at 3:25 PM Alejandro Hernandez <alejandro.hernandez@linux.intel.com> wrote:
When setting USE_NLS="no" and building systemd-boot
(which DEPENDS on intltool), configure fails,
complaining about missing gettext:

configure: error: GNU gettext tools not found; required for intltool

This is caused because USE_NLS="no" makes the gettext class
add gettext-minimal-native to BASEDEPENDS instead of adding
gettext-native.

Since we still would like to set USE_NLS="no" and build systemd-boot,
we add gettext-native as a dependency to intltool-native, which makes it
available for the configure script of systemd-boot fixing the problem.

[YOCTO #11562]

Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
---
 meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
index 551bdf0619a..ecff2faf253 100644
--- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
+++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
@@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = "https://launchpad.net/intltool/trunk/"

 DEPENDS = "libxml-parser-perl-native"
 RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
-DEPENDS_class-native = "libxml-parser-perl-native"
+DEPENDS_class-native = "libxml-parser-perl-native gettext-native"

This will serialise the build I think it better to add the dep only when NLS is down disabled
I thought about doing so but I couldn't think of a clean way of doing it.

I can't get rid of it on the gettext.bbclass since it would mess up the work on b090fde5c184


What I can do, is set gettext-native as a DEPENDS to systemd-boot which is the one that is actually
complaining, this way we would keep returning gettext-minimal-native when USE_NLS="no", but we would
also fix the issue, what do you think?




 inherit autotools pkgconfig perlnative

--
2.12.0

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--------------AA8BC8FE1DF3D58CA163C897--