From: Robert Love <rml@tech9.net>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Stephan von Krawczynski <skraw@ithnet.com>,
Yoshiki Hayashi <yoshiki@xemacs.org>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.16 Fix NULL pointer dereferencing in agpgart_be.c
Date: 17 Dec 2001 14:16:18 -0500 [thread overview]
Message-ID: <1008616583.1705.0.camel@phantasy> (raw)
In-Reply-To: <Pine.LNX.4.21.0112171555190.3340-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0112171555190.3340-100000@freak.distro.conectiva>
On Mon, 2001-12-17 at 12:55, Marcelo Tosatti wrote:
> Well, Stephan, if you could send me only the part which fixes the oops for
> 2.4.17 then I'll be happy.
This patch is sufficient to prevent the oops (check for null pointer),
but as said the full patch from Nicolas is needed for completely correct
operation.
--- linux-2.4.17-rc1/drivers/char/agp/agpgart_be.c Sat Nov 17 03:11:22 2001
+++ linux/drivers/char/agp/agpgart_be.c Sat Dec 15 12:02:51 2001
@@ -3879,7 +3879,7 @@
i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_830_M_1,
NULL);
- if(PCI_FUNC(i810_dev->devfn) != 0) {
+ if(i810_dev != NULL && PCI_FUNC(i810_dev->devfn) != 0) {
i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_830_M_1,
i810_dev);
Robert Love
next prev parent reply other threads:[~2001-12-17 19:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-17 12:50 [PATCH] 2.4.16 Fix NULL pointer dereferencing in agpgart_be.c Yoshiki Hayashi
2001-12-17 13:00 ` Stephan von Krawczynski
2001-12-17 16:49 ` Marcelo Tosatti
2001-12-17 17:55 ` Marcelo Tosatti
2001-12-17 19:16 ` Robert Love [this message]
2001-12-17 23:17 ` Stephan von Krawczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1008616583.1705.0.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=skraw@ithnet.com \
--cc=torvalds@transmeta.com \
--cc=yoshiki@xemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.