From: Valdis.Kletnieks@vt.edu
To: Jian Peng <jipeng2005@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Tejun Heo <tj@kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
Michael Leun <lkml20100708@newton.leun.net>,
linux-ide@vger.kernel.org,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2.6.38-rc7] Revert "libata: ahci_start_engine compliant to AHCI spec"
Date: Fri, 20 May 2011 11:40:20 -0400 [thread overview]
Message-ID: <10124.1305906020@localhost> (raw)
In-Reply-To: Your message of "Wed, 18 May 2011 17:14:56 PDT." <BANLkTim9_1Xt8oE4awbCO1iKUW96YUOv_A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Wed, 18 May 2011 17:14:56 PDT, Jian Peng said:
> > @@ -1353,6 +1332,8 @@
> >
> >
> > ahci_start_engine(ap);
> >
> > + msleep(5);
> > +
> > if (online)
> >
> > *class = ahci_dev_classify(ap);
> >
It may very well be that adding a magic msleep(5) here just Makes It Work, but
I have a gut feeling that it's in the wrong place (for starters, 'online' can't change
during the msleep() unless somebody *else* sets it - in which case the locking
is screwed up as we're not forcing a re-read of the value). The msleep() probably
needs to be before something else further down in the code (but I have no idea
exactly what).
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-05-20 15:41 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 22:25 AHCI driver problem on SB700/SB800 w/ Acer Ferrari One Rafael J. Wysocki
2011-05-13 12:37 ` AHCI driver problem on ICH (Re: AHCI driver problem on SB700/SB800 w/ Acer Ferrari One) Michael Leun
2011-05-13 12:37 ` Michael Leun
2011-05-13 16:56 ` Rafael J. Wysocki
2011-05-13 16:56 ` Rafael J. Wysocki
2011-05-13 17:39 ` Tejun Heo
2011-05-13 17:39 ` Tejun Heo
2011-05-13 19:54 ` Michael Leun
2011-05-13 20:20 ` Rafael J. Wysocki
2011-05-13 20:20 ` Rafael J. Wysocki
2011-05-13 19:54 ` Michael Leun
2011-05-13 20:22 ` Rafael J. Wysocki
2011-05-13 20:22 ` Rafael J. Wysocki
2011-05-13 20:44 ` Rafael J. Wysocki
2011-05-13 20:44 ` Rafael J. Wysocki
2011-05-14 2:08 ` Robert Hancock
2011-05-14 2:08 ` Robert Hancock
2011-05-14 10:18 ` Tejun Heo
2011-05-14 10:28 ` [PATCH v2.6.38-rc7] Revert "libata: ahci_start_engine compliant to AHCI spec" Tejun Heo
2011-05-14 10:28 ` Tejun Heo
2011-05-14 17:47 ` Linus Torvalds
2011-05-14 18:49 ` Jeff Garzik
2011-05-14 18:49 ` Jeff Garzik
2011-05-14 17:47 ` Linus Torvalds
2011-05-15 6:19 ` Jian Peng
2011-05-15 9:25 ` Rafael J. Wysocki
2011-05-15 12:20 ` Michael Leun
2011-05-15 12:20 ` Michael Leun
2011-05-15 9:25 ` Rafael J. Wysocki
2011-05-16 17:02 ` Valdis.Kletnieks
2011-05-16 17:02 ` Valdis.Kletnieks
2011-05-18 19:23 ` Jian Peng
2011-05-18 19:44 ` Rafael J. Wysocki
2011-05-18 21:25 ` Jian Peng
2011-05-19 0:14 ` Jian Peng
2011-05-19 10:19 ` Rafael J. Wysocki
2011-05-19 16:42 ` Jian Peng
2011-05-19 21:32 ` Rafael J. Wysocki
2011-05-19 21:32 ` Rafael J. Wysocki
2011-05-19 21:57 ` Jian Peng
2011-05-19 22:03 ` Rafael J. Wysocki
2011-05-19 22:03 ` Rafael J. Wysocki
2011-05-19 10:19 ` Rafael J. Wysocki
2011-05-20 15:40 ` Valdis.Kletnieks [this message]
2011-05-20 15:43 ` Tejun Heo
2011-05-20 17:02 ` Jian Peng
2011-05-20 18:25 ` Valdis.Kletnieks
2011-05-20 18:25 ` Valdis.Kletnieks
2011-05-22 2:00 ` Jian Peng
2011-05-22 2:00 ` Jian Peng
2011-05-23 12:13 ` Tejun Heo
2011-05-24 1:04 ` Jian Peng
2011-05-24 1:04 ` Jian Peng
2011-05-23 12:13 ` Tejun Heo
2011-05-20 18:21 ` Jian Peng
2011-05-20 18:21 ` Jian Peng
2011-05-20 15:43 ` Tejun Heo
2011-05-20 15:40 ` Valdis.Kletnieks
2011-05-18 19:44 ` Rafael J. Wysocki
2011-05-14 10:28 ` Tejun Heo
2011-05-14 10:18 ` AHCI driver problem on ICH (Re: AHCI driver problem on SB700/SB800 w/ Acer Ferrari One) Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10124.1305906020@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=jgarzik@pobox.com \
--cc=jipeng2005@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=lkml20100708@newton.leun.net \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.