From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] devtools: disable coloring of git-log output
Date: Mon, 19 Nov 2018 00:01:44 +0100 [thread overview]
Message-ID: <10150003.XpIquesuWC@xps> (raw)
In-Reply-To: <20181023085217.18548-1-alialnu@mellanox.com>
23/10/2018 10:52, Ali Alnubani:
> Colored git-log outputs will have escape characters
> appended to hashes, causing check-git-log.sh to fail
> with `error: malformed object name ?[33m<hash>?[m` when doing
> `git tag -l --contains <colored_hash>`.
I guess it is due to a config specifying to color "always".
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> -git log --oneline --reverse $range |
> +git log --no-color --oneline --reverse $range |
There are a lot more "git log" calls in this script.
I wonder whether we should add this option everywhere.
prev parent reply other threads:[~2018-11-18 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 8:52 [PATCH] devtools: disable coloring of git-log output Ali Alnubani
2018-11-18 23:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10150003.XpIquesuWC@xps \
--to=thomas@monjalon.net \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.