From: Robert Love <rml@tech9.net>
To: Maksim Krasnyanskiy <maxk@qualcomm.com>
Cc: fisaksen@bewan.com, mitch@sfgoth.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spinlock not locked when unlocking in atm_dev_register
Date: 01 Mar 2002 17:35:08 -0500 [thread overview]
Message-ID: <1015022109.11499.47.camel@phantasy> (raw)
In-Reply-To: <5.1.0.14.2.20020301143010.0d552be8@mail1.qualcomm.com>
In-Reply-To: <20020301163936.7FA725F963@postfix2-2.free.fr> <20020301163936.7FA725F963@postfix2-2.free.fr> <5.1.0.14.2.20020301143010.0d552be8@mail1.qualcomm.com>
On Fri, 2002-03-01 at 17:32, Maksim Krasnyanskiy wrote:
> > I don't have any knowledge of the source in question, but wouldn't a
> > possibility (perhaps even more likely) be that you should _add_ the
> > spin_lock instead of remove the spin_unlocks ?
>
> Absolutely correct :)
> I've got a patch for that, tested on SMP. I'll send it today or tomorrow.
Yah, I just looked at the code - again, I don't profess to know the atm
driver - but it seems to need the lock. Thanks.
> btw ATM locking seems to be messed up. Is anybody working on that ?
Not that I know of. Volunteer? :)
Robert Love
next prev parent reply other threads:[~2002-03-01 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 17:46 [PATCH] spinlock not locked when unlocking in atm_dev_register Frode Isaksen
2002-03-01 22:15 ` Robert Love
2002-03-04 8:29 ` Frode Isaksen
2002-03-04 18:58 ` Robert Love
2002-03-01 22:32 ` Maksim Krasnyanskiy
2002-03-01 22:35 ` Robert Love [this message]
2002-03-01 22:38 ` David S. Miller
2002-03-01 22:48 ` How to get kernel data using /proc system? Lei Wang
2002-03-02 0:28 ` [PATCH] spinlock not locked when unlocking in atm_dev_register Maksim Krasnyanskiy
2002-03-01 23:06 ` Mitchell Blank Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1015022109.11499.47.camel@phantasy \
--to=rml@tech9.net \
--cc=fisaksen@bewan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mitch@sfgoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.