From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/readahead02: limit max readahead to backing device max_readahead_kb
Date: Thu, 7 Mar 2019 06:25:27 -0500 (EST) [thread overview]
Message-ID: <1016571882.5846458.1551957927293.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAOQ4uxjAJYmUAX85LfFpYw+bGi4ozvSQNfz+v7afR0dp0KfWkQ@mail.gmail.com>
----- Original Message -----
> > > Try to set bdi limit of test device on setup() to testfile_size before
> > > reading
> > > back the value?
> > > If that fails try testfile_size / 2 etc.
> >
> > Maybe, but we would need to start lower (2M). Kernels prior to
> > commit 600e19afc5f8a6c18ea49cee9511c5797db02391 will just ignore it.
> >
>
> Ah. Thanks for the reference.
> But kernels prior to this commit SHOULD fail the test if they
> don't comply with explicit readahead() request that is below 2M
Yes, agreed.
> and bdi limit.
What I meant was, that we can try bumping bdi limit, but our
max readahead length has to be capped to MIN(bdi limit, 2M).
Does that make sense?
> That is the case that the commit sets to fix. No?
>
> Thanks,
> Amir.
>
next prev parent reply other threads:[~2019-03-07 11:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 12:34 [LTP] [PATCH/RFC] syscalls/readahead02: don't use cache size Jan Stancek
2019-03-05 13:53 ` Amir Goldstein
2019-03-05 15:17 ` Jan Stancek
2019-03-05 15:33 ` Amir Goldstein
2019-03-05 16:17 ` [LTP] [PATCH v2] syscalls/readahead02: limit max readahead to backing device max_readahead_kb Jan Stancek
2019-03-05 16:35 ` Amir Goldstein
2019-03-05 16:55 ` Jan Stancek
2019-03-05 20:08 ` Amir Goldstein
2019-03-05 20:22 ` Jan Stancek
2019-03-05 20:44 ` Amir Goldstein
2019-03-06 16:42 ` Jan Stancek
2019-03-07 6:41 ` Amir Goldstein
2019-03-07 8:18 ` Jan Stancek
2019-03-07 8:48 ` Amir Goldstein
2019-03-07 9:15 ` Jan Stancek
2019-03-07 9:53 ` Amir Goldstein
2019-03-07 11:25 ` Jan Stancek [this message]
2019-03-07 11:49 ` Amir Goldstein
2019-03-08 12:19 ` [LTP] [PATCH v4] syscalls/readahead02: set readahead to min(bdi limit, 2M) Jan Stancek
2019-03-08 14:29 ` Amir Goldstein
2019-03-08 14:56 ` Jan Stancek
2019-03-12 13:46 ` Li Wang
2019-03-12 15:26 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1016571882.5846458.1551957927293.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.