From: Robert Love <rml@tech9.net>
To: Andrew Morton <akpm@zip.com.au>
Cc: Roger Larsson <roger.larsson@norran.net>,
Linus Torvalds <torvalds@transmeta.com>,
Dave Hansen <haveblue@us.ibm.com>,
"Adam J. Richter" <adam@yggdrasil.com>,
linux-kernel@vger.kernel.org
Subject: Re: Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() atboot time
Date: 04 Apr 2002 18:16:02 -0500 [thread overview]
Message-ID: <1017962163.22299.653.camel@phantasy> (raw)
In-Reply-To: <3CACDD5D.9A9735A9@zip.com.au>
On Thu, 2002-04-04 at 18:10, Andrew Morton wrote:
> That's changing schedule(). Seems that I'd ruled out that
> option prematurely. As current->preempt_count() and PREEMPT_ACTIVE
> can both evaluate to constant zero if CONFIG_PREEMPT=n, it can
> be done ifdeflessly.
>
> Everything happens inside rq->lock. Looks solid to me.
It is solid - I did not just invent that approach, it was how we have
always done it until around 2.5.6-pre (Ingo sent a patch to change it).
The 2.4 patches do it this way (take a look) and 2.5 before the change
obviously worked like this.
It hasn't shown any problems in ~6 months of use.
I'll cook up a patch to do it, but I'd like to hear Linus opinion ...
Robert Love
next prev parent reply other threads:[~2002-04-04 23:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 11:59 Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() at boot time Adam J. Richter
2002-04-04 12:56 ` Stelian Pop
2002-04-04 13:40 ` Alessandro Suardi
2002-04-04 16:23 ` David C. Hansen
2002-04-04 18:28 ` Dave Hansen
2002-04-04 18:51 ` Robert Love
2002-04-04 19:14 ` Linus Torvalds
2002-04-04 19:26 ` Robert Love
2002-04-04 19:41 ` Dave Hansen
2002-04-04 20:02 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() atboot time george anzinger
2002-04-04 20:54 ` Andrew Morton
2002-04-04 21:34 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() at boot time Roger Larsson
2002-04-04 22:38 ` Andrew Morton
2002-04-04 22:42 ` Linus Torvalds
2002-04-04 22:54 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() atboot time Andrew Morton
2002-04-04 23:07 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() at boot time Robert Love
2002-04-04 23:42 ` Linus Torvalds
2002-04-04 23:47 ` Robert Love
2002-04-04 23:55 ` Linus Torvalds
2002-04-05 0:03 ` [PATCH] preemptive kernel behavior change: don't be rude Robert Love
2002-04-05 1:51 ` george anzinger
2002-04-05 2:06 ` Robert Love
2002-04-04 22:55 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() at boot time Robert Love
2002-04-04 23:10 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() atboot time Andrew Morton
2002-04-04 23:16 ` Robert Love [this message]
2002-04-04 19:13 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() at boot time Linus Torvalds
2002-04-04 19:16 ` Robert Love
2002-04-04 19:45 ` Linus Torvalds
2002-04-04 20:09 ` Patch: linux-2.5.8-pre1/kernel/exit.c change caused BUG() atboot time george anzinger
2002-04-04 19:48 ` george anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1017962163.22299.653.camel@phantasy \
--to=rml@tech9.net \
--cc=adam@yggdrasil.com \
--cc=akpm@zip.com.au \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.larsson@norran.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.