From: Robert Love <rml@tech9.net>
To: Paul P Komkoff Jr <i@stingr.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [CFT][RFC][PATCH][CLEANUP] task->state cleanup: pilot
Date: 06 Apr 2002 18:41:01 -0500 [thread overview]
Message-ID: <1018136462.899.119.camel@phantasy> (raw)
In-Reply-To: <20020406220612.GF839@stingr.net>
On Sat, 2002-04-06 at 17:06, Paul P Komkoff Jr wrote:
> This is the pilot of task->state cleanup in 2.4.x. Feel free to blame me for
> incorrect use of set_task_state vs. __set_task_state
Nice cleanup. Awful lot of [items] in the subject though :)
You don't have to worry about your choices wrt set_current_state vs
__set_current_state - by using only set_current_state you erred on the
side of caution. set_current_state enforces a memory barrier around the
write on SMP (on UP it is the same code) while __set_current_state does
not.
If anyone can verify where it is safe in this code to use
__set_current_state instead, speak up so Paul can make the micro
optimization accordingly.
Robert Love
next prev parent reply other threads:[~2002-04-06 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-06 22:06 [CFT][RFC][PATCH][CLEANUP] task->state cleanup: pilot Paul P Komkoff Jr
2002-04-06 23:41 ` Robert Love [this message]
2002-04-07 11:00 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1018136462.899.119.camel@phantasy \
--to=rml@tech9.net \
--cc=i@stingr.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.