From: Frank Schaefer <frank.schafer@setuza.cz>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.5 patch] hdreg.h must include types.h
Date: 09 Apr 2002 09:37:32 +0200 [thread overview]
Message-ID: <1018337852.620.6.camel@ADMIN> (raw)
In-Reply-To: <Pine.NEB.4.44.0204041640550.7845-100000@mimas.fachschaften.tu-muenchen.de>
On Thu, 2002-04-04 at 16:50, Adrian Bunk wrote:
> On Thu, 4 Apr 2002, Martin Dalecki wrote:
>
> > The proper fix is to add linux/types.h in ide-pnp.c in front
> > of linux/hdreg.h inclusion. Nested includes are *nasty*.
>
> Why are they nasty? My impression is that they give you a cleaner API in
> the sense that you know that when you need something from e.g.
> linux/hdreg.h you can simply include this file without bothering which
> other header files are needed by this file. The only problem I'm currently
> seeing is that circular dependencies between header files might be a
> problem but it shouldn't be too hard to check that there are no circular
> dependencies. Are there any other problems I don't see?
>
Agree,
and assuming that every header begins with sonething like
#ifndef HEADER_INCLUDED
we save a lot of typing and error prone-ness.
Frank
prev parent reply other threads:[~2002-04-09 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 7:42 [2.5 patch] hdreg.h must include types.h Adrian Bunk
2002-04-04 9:18 ` Martin Dalecki
2002-04-04 14:50 ` Adrian Bunk
2002-04-09 7:37 ` Frank Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1018337852.620.6.camel@ADMIN \
--to=frank.schafer@setuza.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.