Re: [PATCH 1/2] signals: sys_ssetmask() uses uninitialized newmask

[CAI Qian <caiqian@redhat.com>]

----- Original Message -----
> From: "Oleg Nesterov" <oleg@redhat.com>
> To: "CAI Qian" <caiqian@redhat.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Linus Torvalds"
> <torvalds@linux-foundation.org>
> Cc: "Linda Wang" <lwang@redhat.com>, "Matt Zywusko" <mzywusko@redhat.com>, "Al Viro" <viro@zeniv.linux.org.uk>,
> linux-kernel@vger.kernel.org
> Sent: Sunday, January 6, 2013 2:13:13 AM
> Subject: [PATCH 1/2] signals: sys_ssetmask() uses uninitialized newmask
> 
> 77097ae5 "most of set_current_blocked() callers want SIGKILL/SIGSTOP
> removed from set" removed the initialization of newmask by accident,
> restore.
> 
> Reported-by: CAI Qian <caiqian@redhat.com>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> Cc: stable@kernel.org	# v3.5+
Thanks Oleg. This is now passing the testing.

Tested-by: CAI Qian <caiqian@redhat.com>
> ---
>  kernel/signal.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 7aaa51d..9692499 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -3286,6 +3286,7 @@ SYSCALL_DEFINE1(ssetmask, int, newmask)
>  	int old = current->blocked.sig[0];
>  	sigset_t newset;
>  
> +	siginitset(&newset, newmask);
>  	set_current_blocked(&newset);
>  
>  	return old;
> --
> 1.5.5.1
> 
> 
>