Re: [reiserfs-dev] [BK] [2.4] Reiserfs changeset 2 out of 4, please apply.

[Chris Mason <mason@suse.com>]

On Tue, 2002-05-07 at 11:05, Hans Reiser wrote:
> Hello!
> 
>  You can get this changeset from bk://thebsh.namesys.com/bk/reiser3-linux-2.4
> 
>  This changeset are cleaning up reiserfscode, removes stale comments, and
>  rewrites some "borrowed" functions so that all of the code in reiserfs subdir
>  should now only belong to NAMESYS.

It is the end of a release cycle on a stable kernel with huge changes to
the IDE layer, and we have at least one unconfirmed report of problems
with reiserfs+IDE after a crash.

This is not the right time to send in cleanups like this, especially
when they bits as useless as the stuff below.  #1, #2 and #4 look like
valid fixes.  #3 should probably be mixed with the iput deadlock fix
like Oleg did in 2.5, and should wait until after 2.4.19.

-chris

@@ -957,6 +875,7 @@
     int windex ;
     struct reiserfs_transaction_handle th ;
     int jbegin_count = JOURNAL_PER_BALANCE_CNT * 3; 
+    time_t ctime;
 
 
     if (S_ISDIR(inode->i_mode))
@@ -984,7 +903,8 @@
     }
 
     inode->i_nlink++;
-    inode->i_ctime = CURRENT_TIME;
+    ctime = CURRENT_TIME;
+    inode->i_ctime = ctime;
     reiserfs_update_sd (&th, inode);
 
     atomic_inc(&inode->i_count) ;
@@ -1037,14 +957,6 @@
 }