From: Luca Barbieri <ldb@ldb.ods.org>
To: Linus Torvalds <torvalds@transmeta.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: mitch@sfgoth.com, linux-kernel@vger.kernel.org,
linux-ppp@vger.kernel.org
Subject: [PATCH] [2.4] [2.5] Fix PPPoATM crash on disconnection (tasklet_disable; kfree(tasklet))
Date: 11 May 2002 21:19:31 +0200 [thread overview]
Message-ID: <1021144771.3909.27.camel@ldb> (raw)
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
PPPoATM uses tasklet_disable() on a tasklet inside a struct and then
frees the struct, leaving a pointer to the freed tasklet inside tasklet
lists.
This patch replaces tasklet_disable() with tasklet_kill().
This bug is present in both 2.4.18 and 2.5.15 (and the patch applies to
both).
--- linux-old/net/atm/pppoatm.c Wed Apr 10 14:37:34 2002
+++ linux/net/atm/pppoatm.c Fri May 10 21:56:28 2002
@@ -125,7 +125,7 @@
pvcc = atmvcc_to_pvcc(atmvcc);
atmvcc->push = pvcc->old_push;
atmvcc->pop = pvcc->old_pop;
- tasklet_disable(&pvcc->wakeup_tasklet);
+ tasklet_kill(&pvcc->wakeup_tasklet);
ppp_unregister_channel(&pvcc->chan);
atmvcc->user_back = NULL;
kfree(pvcc);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]
reply other threads:[~2002-05-11 19:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1021144771.3909.27.camel@ldb \
--to=ldb@ldb.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=mitch@sfgoth.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.