All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Josefsson <gandalf@wlug.westbo.se>
To: Henrik Nordstrom <hno@marasystems.com>
Cc: Netfilter-devel <netfilter-devel@lists.samba.org>
Subject: Re: [PATCH] remove exessive timer updates (3/4)
Date: 13 Jun 2002 18:17:41 +0200	[thread overview]
Message-ID: <1023985062.19816.368.camel@tux> (raw)
In-Reply-To: <200206131407.39752@henrik.marasystems.com>

On Thu, 2002-06-13 at 14:07, Henrik Nordstrom wrote:
> On Wednesday 12 June 2002 21:02, Martin Josefsson wrote:
> 
> > It adds a new parameter to ip_ct_refresh called force, if set to
> > non-zero a timer update will be forced.
> 
> Hmm.. this may be a little hard to enforce at all times..
> 
> Why don't you make the filter simply filter out any timer updates that 
> would increase the timer by less than HZ?
> 
>   change = new_interval - current_remaining_time
> 
>   if (change < 0 || change >= HZ)
>      update the timer
> 
> Feels both cleaner and safer to me..

This sounds like a very good idea, it's a good thing I have you guys to
straighten me out :)

Will send new patch later this evening. And I'll even test it before
sending :)

-- 
/Martin

Never argue with an idiot. They drag you down to their level, then beat
you with experience.

      reply	other threads:[~2002-06-13 16:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-06 12:24 [PATCH] remove exessive timer updates (3/4) Martin Josefsson
2002-06-08  7:37 ` Harald Welte
2002-06-08 15:03   ` Martin Josefsson
2002-06-09 17:17     ` Harald Welte
2002-06-11  7:59 ` Harald Welte
2002-06-11 22:21   ` Henrik Nordstrom
2002-06-12  9:10     ` Martin Josefsson
2002-06-12 19:02       ` Martin Josefsson
2002-06-13 12:07         ` Henrik Nordstrom
2002-06-13 16:17           ` Martin Josefsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1023985062.19816.368.camel@tux \
    --to=gandalf@wlug.westbo.se \
    --cc=hno@marasystems.com \
    --cc=netfilter-devel@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.