Harald Ok, here is the first cut of a set of patches. The only thing missing is the Makefile modifications. My knowledge of the fine art of Makefile writing is sorely lacking, so any help on that front, from anybody, would be greatly appreciated. The helper functions have been placed in a libipt_dscp_helper.c file in the extensions directory. Both the DSCP match and target have been modified to use the new functions. Iain On Tue, 2002-06-11 at 08:41, Harald Welte wrote: > On Mon, Jun 10, 2002 at 01:49:13PM +0000, zenadsl3030@zen.co.uk wrote: > > Hi, > > > > Here is a simple patch to the DSCP match to allow the use of DiffServ class > > names in the matches, in a similar manner to the target. > > > > Also attached is a one line fix for a typo in the DSCP target where CS6 was > > defined twice in the match list. > > thanks for your contribution. What about putting all the class name <-> > numerical resolving in a seperate .c file, which is then compiled once and > linked into both libipt_dscp.so and libipt_DSCP.so ? > > I think this would be the ideal case, without any code duplication. > > > Iain > > -- > Live long and prosper > - Harald Welte / laforge@gnumonks.org http://www.gnumonks.org/ > ============================================================================ > GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+ > V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*) -- Iain Barnes