All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: select targets in build test
Date: Thu, 04 Feb 2021 14:59:42 +0100	[thread overview]
Message-ID: <10271511.8fBPl8u87h@thomas> (raw)
In-Reply-To: <20210204133435.3117-1-david.marchand@redhat.com>

04/02/2021 14:34, David Marchand:
> When a target compilation is broken, one way to skip the target is to
> uninstall the associated toolchain.
> But it is not always possible and you end up with hacking the script to
> avoid this target until a fix is ready.
> 
> It is also often quicker to check a fix on a failing target before
> checking compilation on all targets.
> 
> Introduce a variable to select targets.
> 
> Example:
> $ DPDK_BUILD_TEST_TARGETS=build-x86-mingw \
>     ./devtools/test-meson-builds.sh

With this solution, you need to list all targets you want to compile.

An alternative could be to disable a target in the config file
based on the variable DPDK_TARGET set by load_env.
One hack, which does not need any change in the script I think,
is to set targetcc=disabled.
Or we could check a well defined variable after calling load-devel-config.

[...]
> +target_is_selected build-x86-default || exit 0

Why this line?




  reply	other threads:[~2021-02-04 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 13:34 [dpdk-dev] [PATCH] devtools: select targets in build test David Marchand
2021-02-04 13:59 ` Thomas Monjalon [this message]
2021-02-04 14:48   ` David Marchand
2021-02-04 15:48     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10271511.8fBPl8u87h@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.