From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, "Jose R. Santos" <jrsantos@austin.ibm.com>
Subject: Re: 2.6.8-rc1-mm1
Date: Wed, 14 Jul 2004 09:11:29 +0100 [thread overview]
Message-ID: <10289.1089792689@redhat.com> (raw)
In-Reply-To: <20040714002912.26ed0e66.akpm@osdl.org>
> btw, David, I'm wondering about this loop:
>
> do {
> size = bucketsize << log2qty;
>
> table = (void *) alloc_bootmem(size);
>
> } while (!table && size > PAGE_SIZE);
>
> Is this a busy-wait-until-someone-plugs-in-more-ram-chips thing? ;)
Well, with IBM hardware, you never know:-)
Yeah... that got fixed here in my 2.4 version, and I failed to transfer the
fix across. log2qty should be decremented every time around the loop:
- } while (!table && size > PAGE_SIZE);
+ } while (!table && size > PAGE_SIZE && --log2qty);
David
next prev parent reply other threads:[~2004-07-14 8:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 1:25 2.6.8-rc1-mm1 Andrew Morton
2004-07-14 7:29 ` 2.6.8-rc1-mm1 Andrew Morton
2004-07-14 8:11 ` David Howells [this message]
2004-07-14 16:36 ` 2.6.8-rc1-mm1 John Cherry
2004-07-14 18:49 ` [patch] 2.6.8-rc1-mm1: USB w9968cf compile error Adrian Bunk
2004-07-14 19:03 ` Greg KH
2004-07-14 19:08 ` Adrian Bunk
2004-07-14 20:29 ` 2.6.8-rc1-mm1 Dominik Karall
2004-07-14 20:43 ` [patch] 2.6.8-rc1-mm1: 8139too: uninline rtl8139_start_thread Adrian Bunk
2004-07-14 20:45 ` Jeff Garzik
2004-07-27 18:00 ` Jeff Garzik
2004-07-14 21:08 ` 2.6.8-rc1-mm1 Dominik Karall
2004-07-14 21:53 ` 2.6.8-rc1-mm1 Tim Bird
2004-07-15 10:35 ` 2.6.8-rc1-mm1 Ralf Hildebrandt
2004-07-18 3:53 ` [patch] 2.6.8-rc1-mm1: work around broken USB DocBook generation Adrian Bunk
2004-07-20 0:02 ` 2.6.8-rc1-mm1 J.A. Magallon
2004-07-22 12:56 ` 2.6.8-rc1-mm1 Jens Axboe
2004-07-20 0:05 ` 2.6.8-rc1-mm1 J.A. Magallon
-- strict thread matches above, loose matches on Subject: below --
2004-07-15 3:33 2.6.8-rc1-mm1 Diffie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10289.1089792689@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=jrsantos@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.