All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoann Vandoorselaere <yoann@prelude-ids.org>
To: cpufreq@lists.arm.linux.org
Cc: cpufreq@www.linux.org.uk, linux-kernel@vger.kernel.org,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Subject: [PATCH]: fix 32bits integer overflow in loops_per_jiffy calculation
Date: 22 Aug 2002 11:50:40 +0200	[thread overview]
Message-ID: <1030009840.15429.109.camel@alph> (raw)

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi,

The "low_part * mult" multiplication of the old function may overflow a
32bits integer...

This patch both fix the overflow issue (tested with frequencies up to
20Ghz), and make the result of the function lose less precision.

Please apply, 

-- 
Yoann Vandoorselaere, http://www.prelude-ids.org

"Programming is a race between programmers, who try and make more and 
 more idiot-proof software, and universe, which produces more and more 
 remarkable idiots. Until now, universe leads the race"  -- R. Cook

[-- Attachment #2: cpufreq-overflow.diff --]
[-- Type: text/plain, Size: 747 bytes --]

--- linux-benh/kernel/cpufreq.c	2002-08-21 17:27:52.000000000 +0200
+++ linux-yoann/kernel/cpufreq.c	2002-08-22 11:27:09.000000000 +0200
@@ -78,14 +78,16 @@ static unsigned int             cpufreq_
  */
 static unsigned long scale(unsigned long old, u_int div, u_int mult)
 {
-	unsigned long low_part, high_part;
-
-	high_part  = old / div;
-	low_part   = (old % div) / 100;
-	high_part *= mult;
-	low_part   = low_part * mult / div;
-
-	return high_part + low_part * 100;
+        unsigned long val, carry = 0;
+        
+        mult /= 100;
+        div  /= 100;
+        val = old / div * mult;
+
+        carry = old % div;
+        carry = carry * mult / div;
+                
+        return val + carry;
 }
 
 

             reply	other threads:[~2002-08-22  9:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-22  9:50 Yoann Vandoorselaere [this message]
2002-08-22 10:21 ` [PATCH]: fix 32bits integer overflow in loops_per_jiffy calculation Gabriel Paubert
2002-08-22 13:00   ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2002-08-22 13:02 Benjamin Herrenschmidt
2002-08-22 12:12 ` Gabriel Paubert
2002-08-22 14:31   ` Benjamin Herrenschmidt
2002-08-22 15:23     ` Gabriel Paubert
2002-08-22 15:59       ` Yoann Vandoorselaere
2002-08-22 16:51       ` Dominik Brodowski
2002-08-22 19:35         ` Benjamin Herrenschmidt
2002-08-22 17:46           ` Dominik Brodowski
2002-08-22 18:02             ` Yoann Vandoorselaere
2002-08-22 20:00             ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030009840.15429.109.camel@alph \
    --to=yoann@prelude-ids.org \
    --cc=benh@kernel.crashing.org \
    --cc=cpufreq@lists.arm.linux.org \
    --cc=cpufreq@www.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.