From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPQwk-0005Xi-Rr for qemu-devel@nongnu.org; Tue, 19 Jul 2016 05:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPQwf-00017I-OB for qemu-devel@nongnu.org; Tue, 19 Jul 2016 05:04:09 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:51756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPQwf-00017D-HD for qemu-devel@nongnu.org; Tue, 19 Jul 2016 05:04:05 -0400 Date: Tue, 19 Jul 2016 05:04:03 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1030104469.6333972.1468919043003.JavaMail.zimbra@redhat.com> In-Reply-To: <20160719085432.4572-35-marcandre.lureau@redhat.com> References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-35-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 34/37] tests: pc-cpu-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre lureau Cc: qemu-devel@nongnu.org Hi, Sorry, nack that one, it is missing some explanations, signed-off etc. ----- Original Message ----- > From: Marc-Andr=C3=A9 Lureau >=20 > --- > tests/pc-cpu-test.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/pc-cpu-test.c b/tests/pc-cpu-test.c > index 4428cea..06afca3 100644 > --- a/tests/pc-cpu-test.c > +++ b/tests/pc-cpu-test.c > @@ -78,7 +78,8 @@ static void add_pc_test_cases(void) > const QListEntry *p; > QObject *qobj; > QString *qstr; > - const char *mname, *path; > + const char *mname; > + char *path; > PCTestData *data; > =20 > qtest_start("-machine none"); > @@ -99,7 +100,7 @@ static void add_pc_test_cases(void) > continue; > } > data =3D g_malloc(sizeof(PCTestData)); > - data->machine =3D mname; > + data->machine =3D g_strdup(mname); > data->cpu_model =3D "Haswell"; /* 1.3+ theoretically */ > data->sockets =3D 1; > data->cores =3D 3; > @@ -120,13 +121,16 @@ static void add_pc_test_cases(void) > mname, data->sockets, data->cores, > data->threads, data->maxcpus); > qtest_add_data_func(path, data, test_pc_without_cpu_add); > + g_free(path); > } else { > path =3D g_strdup_printf("cpu/%s/add/%ux%ux%u&maxcpus=3D%u", > mname, data->sockets, data->cores, > data->threads, data->maxcpus); > qtest_add_data_func(path, data, test_pc_with_cpu_add); > + g_free(path); > } > } > + QDECREF(response); > qtest_end(); > } > =20 > -- > 2.9.0 >=20 >=20