From: Antonino Daplas <adaplas@pol.net>
To: Jani Monoses <jani@iv.ro>,
fbdev <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: gen_set_var() fix?
Date: 28 Aug 2002 17:03:26 +0800 [thread overview]
Message-ID: <1030525403.632.7.camel@daplas> (raw)
In-Reply-To: <20020828100048.2dde942e.jani@iv.ro>
On Wed, 2002-08-28 at 18:00, Jani Monoses wrote:
> James
> Should't gen_set_var set the var in info here as well? (when no check_var present)
> BTW is gen_set_var going to stay in the new API or go away ?
>
> --- fbgen.c.orig Wed Aug 28 09:49:45 2002
> +++ fbgen.c Wed Aug 28 09:57:32 2002
> @@ -36,7 +36,7 @@
>
> if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) {
> if (!info->fbops->fb_check_var) {
> - *var = info->var;
> + info->var = *var;
> return 0;
> }
>
>
The original code is correct. It means the driver supports only 1 video
mode, which is the current one in info->var.
Tony
-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing
real-time communications platform! Don't just IM. Build it in!
http://www.jabber.com/osdn/xim
next prev parent reply other threads:[~2002-08-28 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-28 10:00 gen_set_var() fix? Jani Monoses
2002-08-28 9:03 ` Antonino Daplas [this message]
2002-08-28 12:16 ` Jani Monoses
2002-08-28 9:19 ` Geert Uytterhoeven
2002-08-28 18:14 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030525403.632.7.camel@daplas \
--to=adaplas@pol.net \
--cc=jani@iv.ro \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.