From: Robert Love <rml@tech9.net>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: alan@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4-ac task->cpu abstraction and optimization
Date: 12 Sep 2002 14:23:52 -0400 [thread overview]
Message-ID: <1031855035.2958.5.camel@phantasy> (raw)
In-Reply-To: <15744.14760.938667.636159@kim.it.uu.se>
On Thu, 2002-09-12 at 02:52, Mikael Pettersson wrote:
> This is fairly similar to the "up-opt" patch I have been using for my
> 2.4 standard (not -ac) kernels since last winter, available as
> <http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-up-opt-2.4.20-pre6>.
> It's not a direct substitute for yours, since -ac changes kernel/sched.c
> quite a bit, and it has some unnecessary patches to SMP code, but other
> than that, I totally agree with the intention of your patch.
Good ;)
I should of added this is from 2.5; so it has been around for awhile. I
also took a look at your patch -- looks good, you should submit it to
Marcelo... it cannot hurt for 2.4.
One thing:
- int processor;
+#ifdef CONFIG_SMP
+ int processor; /* keep old name to avoid upsetting all archs */
+#endif
It is normally bad form to have conditionally entries in the
task_struct... otherwise, looks good.
Robert Love
next prev parent reply other threads:[~2002-09-12 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-11 22:21 [PATCH] 2.4-ac task->cpu abstraction and optimization Robert Love
2002-09-12 6:52 ` Mikael Pettersson
2002-09-12 18:23 ` Robert Love [this message]
2002-09-12 18:37 ` Mikael Pettersson
2002-09-12 20:22 ` Alan Cox
[not found] <15744.57073.2852.707839@kim.it.uu.se.suse.lists.linux.kernel>
[not found] ` <200209122022.g8CKMJS15137@devserv.devel.redhat.com.suse.lists.linux.kernel>
2002-09-12 20:55 ` Andi Kleen
2002-09-12 21:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031855035.2958.5.camel@phantasy \
--to=rml@tech9.net \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.