All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Josefsson <gandalf@wlug.westbo.se>
To: Jarno Paananen <jpaana@s2.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4.20-pre7] net/ipv4/netfilter/ip_conntrack_ftp and _irc to export objs
Date: 14 Sep 2002 20:11:45 +0200	[thread overview]
Message-ID: <1032027105.29595.129.camel@tux> (raw)
In-Reply-To: <m3vg58qwz1.fsf@kalahari.s2.org>

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

On Sat, 2002-09-14 at 19:53, Jarno Paananen wrote:
> Hi,
> 
> the two modules mentioned export symbols but are not mentioned in
> export-objs in Makefile and thus give errors. Patch attached.
> 
> // Jarno
> 
> --- net/ipv4/netfilter/Makefile.bak	2002-09-14 19:50:38.000000000 +0300
> +++ net/ipv4/netfilter/Makefile	2002-09-14 19:51:28.000000000 +0300
> @@ -9,7 +9,7 @@
>  
>  O_TARGET := netfilter.o
>  
> -export-objs = ip_conntrack_standalone.o ip_fw_compat.o ip_nat_standalone.o ip_tables.o arp_tables.o
> +export-objs = ip_conntrack_standalone.o ip_fw_compat.o ip_nat_standalone.o ip_tables.o arp_tables.o ip_conntrack_ftp.o ip_conntrack_irc.o
>  
>  # Multipart objects.
>  list-multi		:= ip_conntrack.o iptable_nat.o ipfwadm.o ipchains.o

Did you see this part starting at row 34?

# connection tracking helpers
obj-$(CONFIG_IP_NF_FTP) += ip_conntrack_ftp.o
ifdef CONFIG_IP_NF_NAT_FTP
        export-objs += ip_conntrack_ftp.o
endif

obj-$(CONFIG_IP_NF_IRC) += ip_conntrack_irc.o
ifdef CONFIG_IP_NF_NAT_IRC
        export-objs += ip_conntrack_irc.o
endif

but maybe the ifdefs shouldn't use the NAT define...
I don't think I've compiled without NAT support...
 
-- 
/Martin

Never argue with an idiot. They drag you down to their level, then beat
you with experience.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2002-09-14 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-14 17:53 [PATCH 2.4.20-pre7] net/ipv4/netfilter/ip_conntrack_ftp and _irc to export objs Jarno Paananen
2002-09-14 18:11 ` Martin Josefsson [this message]
2002-09-14 18:19   ` Jarno Paananen
2002-09-14 18:37     ` Martin Josefsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1032027105.29595.129.camel@tux \
    --to=gandalf@wlug.westbo.se \
    --cc=jpaana@s2.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.